linux-kernel - Re: [PATCH wireless-next] wifi: mac80211: reject VHT opmode for unsupported channel widths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF3JpA5NX4s5XrUvOfVg59oOmfFMHoZ0e5+yHynRYifbPY05Mw@mail.gmail.com>
Date: Thu, 3 Jul 2025 11:45:08 -0700
From: Moonhee Lee <moonhee.lee.ca@...il.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: Nicolas Escande <nico.escande@...il.com>, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev, 
	syzbot+ededba317ddeca8b3f08@...kaller.appspotmail.com
Subject: Re: [PATCH wireless-next] wifi: mac80211: reject VHT opmode for
 unsupported channel widths

On Thu, Jul 3, 2025 at 9:54 AM Johannes Berg <johannes@...solutions.net> wrote:
>
> I think it'd make more sense to go the other way around and list the
> bandwidths that are _valid_ here, even if I don't see it getting
> extended any time soon (anyone working on TVHT? ;-) )
>
> But in some way I also have a feeling we _should_ be able to reject this
> in cfg80211 already - although it seems that right now we cannot. Hmm. I
> guess better to have this validation here now than fail/WARN, but then
> I'd like a positive list of allowed values, rather than forbidden ones.

Thank you for the feedback.

I agree it is clearer to apply a positive list of valid channel widths rather
than excluding specific ones. I will update v2 accordingly, and drop
NL80211_CHAN_WIDTH_20_NOHT from the current patch as well. This ensures only
the valid set is accepted, while preventing the WARN_ON from being triggered.

Best regards,
Moonhee