linux-kernel - Re: [PATCH v2 3/3] cma: move memory allocation to a helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfc1c95f-3e3c-4856-b831-bffaa6457c03@redhat.com>
Date: Thu, 3 Jul 2025 20:52:59 +0200
From: David Hildenbrand <david@...hat.com>
To: Mike Rapoport <rppt@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Alexandre Ghiti <alexghiti@...osinc.com>,
 Oscar Salvador <osalvador@...e.de>, Pratyush Yadav <ptyadav@...zon.de>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 3/3] cma: move memory allocation to a helper function

On 03.07.25 20:47, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
> 
> __cma_declare_contiguous_nid() tries to allocate memory in several ways:
> * on systems with 64 bit physical address and enough memory it first
>    attempts to allocate memory just above 4GiB
> * if that fails, on systems with HIGHMEM the next attempt is from high
>    memory
> * and at last, if none of the previous attempts succeeded, or was even
>    tried because of incompatible configuration, the memory is allocated
>    anywhere within specified limits.
> 
> Move all the allocation logic to a helper function to make these steps more
> obvious.
> 
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> ---

LGTM, thanks!

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb