linux-kernel - Re: [PATCH v2] pinctrl: qcom: add multi TLMM region option parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbh1oikr=2A_ymAupE+j5nc2pfgU3m2DteEUdqY6=Ertw@mail.gmail.com>
Date: Thu, 3 Jul 2025 23:45:05 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Yuanjie Yang <quic_yuanjiey@...cinc.com>
Cc: andersson@...nel.org, linux-arm-msm@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel@....qualcomm.com, quic_tingweiz@...cinc.com
Subject: Re: [PATCH v2] pinctrl: qcom: add multi TLMM region option parameter

On Tue, Jun 24, 2025 at 11:06 AM Yuanjie Yang <quic_yuanjiey@...cinc.com> wrote:

> Add support for selecting multiple TLMM regions using the
> tlmm-test tool.
> The current implementation only selects the TLMM Node region
> 0, which can lead to incorrect region selection.
>
> QCS 615 TLMM Node dts reg:
>         tlmm: pinctrl@...0000 {
>                 compatible = "qcom,qcs615-tlmm";
>                 reg = <0x0 0x03100000 0x0 0x300000>,
>                       <0x0 0x03500000 0x0 0x300000>,
>                       <0x0 0x03d00000 0x0 0x300000>;
>                 reg-names = "east",
>                             "west",
>                             "south";
>
> QCS615 gpio57 is in the south region with an offset of 0x39000,
> and its address is 0x3d39000. However, the default region selection
> is region 0 (east region), resulting in a wrong calculated address
> of 0x3139000.
>
> Add a tlmm option parameter named tlmm_reg_name to select the region.
> If the user does not input the parameter, the default region is 0.
>
> Signed-off-by: Yuanjie Yang <quic_yuanjiey@...cinc.com>

I don't understand the test tool but it looks reasonable to me
so patch applied!

Yours,
Linus Walleij