linux-kernel - Re: [PATCH] drm/nouveau: Do not fail module init on debugfs errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGcCz5VU1lbi_ZxD@pollux>
Date: Fri, 4 Jul 2025 00:23:11 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Aaron Thompson <dev@...ont.org>
Cc: nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	Lyude Paul <lyude@...hat.com>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, Timur Tabi <ttabi@...dia.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau: Do not fail module init on debugfs errors

On Thu, Jul 03, 2025 at 09:19:49PM +0000, Aaron Thompson wrote:
> From: Aaron Thompson <dev@...ont.org>
> 
> If CONFIG_DEBUG_FS is enabled, nouveau_drm_init() returns an error if it
> fails to create the "nouveau" directory in debugfs. One case where that
> will happen is when debugfs access is restricted by
> CONFIG_DEBUG_FS_ALLOW_NONE or by the boot parameter debugfs=off, which
> cause the debugfs APIs to return -EPERM.
> 
> So just ignore errors from debugfs. Note that nouveau_debugfs_root may
> be an error now, but that is a standard pattern for debugfs. From
> include/linux/debugfs.h:
> 
> "NOTE: it's expected that most callers should _ignore_ the errors
> returned by this function. Other debugfs functions handle the fact that
> the "dentry" passed to them could be an error and they don't crash in
> that case. Drivers should generally work fine even if debugfs fails to
> init anyway."
> 
> Fixes: 97118a1816d2 ("drm/nouveau: create module debugfs root")
> Cc: stable@...r.kernel.org
> Signed-off-by: Aaron Thompson <dev@...ont.org>

Applied to drm-misc-fixes, thanks!