linux-kernel - [RESEND PATCH] coccinelle: misc: secs_to_jiffies: Implement context and report modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250703225145.152288-1-eahariha@linux.microsoft.com>
Date: Thu,  3 Jul 2025 15:51:32 -0700
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Julia Lawall <Julia.Lawall@...ia.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Easwar Hariharan <eahariha@...ux.microsoft.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	cocci@...ia.fr (moderated list:COCCINELLE/Semantic Patches (SmPL)),
	linux-kernel@...r.kernel.org (open list)
Cc: Jakub Kicinski <kuba@...nel.org>,
	Ricardo Ribalda <ribalda@...omium.org>
Subject: [RESEND PATCH] coccinelle: misc: secs_to_jiffies: Implement context and report modes

As requested by Ricardo and Jakub, implement report and context  modes
for the secs_to_jiffies Coccinelle script. While here, add the option to
look for opportunities to use secs_to_jiffies() in headers.

Cc: Jakub Kicinski <kuba@...nel.org>
Cc: Ricardo Ribalda <ribalda@...omium.org>
Closes: https://lore.kernel.org/all/20250129-secs_to_jiffles-v1-1-35a5e16b9f03@chromium.org/
Closes: https://lore.kernel.org/all/20250221162107.409ae333@kernel.org/
Tested-by: Ricardo Ribalda <ribalda@...omium.org>
Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
---
 scripts/coccinelle/misc/secs_to_jiffies.cocci | 49 +++++++++++++++++--
 1 file changed, 44 insertions(+), 5 deletions(-)

diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci
index 416f348174ca..f3241ce75a7b 100644
--- a/scripts/coccinelle/misc/secs_to_jiffies.cocci
+++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci
@@ -7,26 +7,65 @@
 // Confidence: High
 // Copyright: (C) 2024 Easwar Hariharan, Microsoft
 // Keywords: secs, seconds, jiffies
-//
+// Options: --include-headers
 
 virtual patch
+virtual report
+virtual context
 
-@...ends on patch@ constant C; @@
+@...nst depends on patch@ constant C; @@
 
 - msecs_to_jiffies(C * 1000)
 + secs_to_jiffies(C)
 
-@...ends on patch@ constant C; @@
+@...nstms depends on patch@ constant C; @@
 
 - msecs_to_jiffies(C * MSEC_PER_SEC)
 + secs_to_jiffies(C)
 
-@...ends on patch@ expression E; @@
+@...pr depends on patch@ expression E; @@
 
 - msecs_to_jiffies(E * 1000)
 + secs_to_jiffies(E)
 
-@...ends on patch@ expression E; @@
+@...prms depends on patch@ expression E; @@
 
 - msecs_to_jiffies(E * MSEC_PER_SEC)
 + secs_to_jiffies(E)
+
+@r depends on report && !patch@
+constant C;
+expression E;
+position p;
+@@
+
+(
+  msecs_to_jiffies(C@p * 1000)
+|
+  msecs_to_jiffies(C@p * MSEC_PER_SEC)
+|
+  msecs_to_jiffies(E@p * 1000)
+|
+  msecs_to_jiffies(E@p * MSEC_PER_SEC)
+)
+
+@c depends on context && !patch@
+constant C;
+expression E;
+@@
+
+(
+* msecs_to_jiffies(C * 1000)
+|
+* msecs_to_jiffies(C * MSEC_PER_SEC)
+|
+* msecs_to_jiffies(E * 1000)
+|
+* msecs_to_jiffies(E * MSEC_PER_SEC)
+)
+
+@...ipt:python depends on report@
+p << r.p;
+@@
+
+coccilib.report.print_report(p[0], "WARNING opportunity for secs_to_jiffies()")
-- 
2.43.0