linux-kernel - Re: [PATCH 1/6] arm64: dts: renesas: r9a09g077: Add I2C controller nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8uTbEfD+egzRHjw6og=mh-+WzhwLVT6gZPi6OHjAdLEQQ@mail.gmail.com>
Date: Fri, 4 Jul 2025 00:51:22 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 1/6] arm64: dts: renesas: r9a09g077: Add I2C controller nodes

Hi Geert,

Thank you for the review.

On Thu, Jul 3, 2025 at 10:45 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, 25 Jun 2025 at 17:30, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > The Renesas RZ/T2H ("R9A09G077") SoC includes three I2C (RIIC) channels.
> > Adds the device tree nodes for all three I2C controllers to RZ/T2H
> > SoC DTSI.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> > @@ -90,6 +90,51 @@ sci0: serial@...05000 {
> >                         status = "disabled";
> >                 };
> >
> > +               i2c0: i2c@...88000 {
> > +                       compatible = "renesas,riic-r9a09g077";
> > +                       reg = <0 0x80088000 0 0x400>;
> > +                       interrupts = <GIC_SPI 614 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 615 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 616 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 617 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "eei", "rxi", "txi", "tei";
> > +                       clocks = <&cpg CPG_MOD 100>;
> > +                       power-domains = <&cpg>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +                       status = "disabled";
> > +               };
> > +
> > +               i2c1: i2c@...88004 {
>
> 80088400
>
Agreed.

> Aha, the related warning was demoted to W=1:
>
Thanks for the hint, I always ran it with W=2.

>     Warning (simple_bus_reg): /soc/i2c@...88004: simple-bus unit
> address format error, expected "80088400"
>

> > +                       compatible = "renesas,riic-r9a09g077";
> > +                       reg = <0 0x80088400 0 0x400>;
> > +                       interrupts = <GIC_SPI 618 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 619 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 620 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 621 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "eei", "rxi", "txi", "tei";
> > +                       clocks = <&cpg CPG_MOD 101>;
> > +                       power-domains = <&cpg>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +                       status = "disabled";
> > +               };
> > +
> > +               i2c2: i2c@...08000 {
> > +                       compatible = "renesas,riic-r9a09g077";
> > +                       reg = <0 0x81008000 0 0x400>;
> > +                       interrupts = <GIC_SPI 622 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 623 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 624 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 625 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "eei", "rxi", "txi", "tei";
> > +                       clocks = <&cpg CPG_MOD 501>;
>
> 601
>
Agreed.

Cheers,
Prabhakar