linux-kernel - Re: [PATCH v2 2/3] pinctrl: renesas: Add support for RZ/T2H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8uZX9uzCqqk-wuTOB67UxXOOWP9+aE2HacDnX+ZATgo=Q@mail.gmail.com>
Date: Fri, 4 Jul 2025 00:53:17 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, Bartosz Golaszewski <brgl@...ev.pl>, linux-renesas-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 2/3] pinctrl: renesas: Add support for RZ/T2H

Hi Geert,

Thank you for the review.

On Thu, Jul 3, 2025 at 11:02 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, 25 Jun 2025 at 15:07, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> >
> > Add the pinctrl and gpio driver for RZ/T2H
> >
> > Signed-off-by: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> > Co-developed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > v1->v2:
> > - All the regions are now accessed by reg names
> > - Added support to validate the pins
>
> Thanks for the update!
>
> > --- a/drivers/pinctrl/renesas/Kconfig
> > +++ b/drivers/pinctrl/renesas/Kconfig
> > @@ -44,6 +44,7 @@ config PINCTRL_RENESAS
> >         select PINCTRL_RZG2L if ARCH_R9A09G047
> >         select PINCTRL_RZG2L if ARCH_R9A09G056
> >         select PINCTRL_RZG2L if ARCH_R9A09G057
> > +       select PINCTRL_RZT2H if ARCH_R9A09G077
> >         select PINCTRL_PFC_SH7203 if CPU_SUBTYPE_SH7203
> >         select PINCTRL_PFC_SH7264 if CPU_SUBTYPE_SH7264
> >         select PINCTRL_PFC_SH7269 if CPU_SUBTYPE_SH7269
> > @@ -249,6 +250,18 @@ config PINCTRL_RZN1
> >         help
> >           This selects pinctrl driver for Renesas RZ/N1 devices.
> >
> > +config PINCTRL_RZT2H
> > +       bool "pin control support for RZ/T2H"
> > +       depends on OF
> > +       depends on ARCH_R9A09G077 || COMPILE_TEST
>
> This line is not needed, as PINCTRL_RZT2H is selected above (On RZ/A1,
> RZ/A2, and RZ/N1, the pin control driver is optional).  Please move the
> "|| COMPILE_TEST" to the prompt, like is done for most other drivers.
>
Ok, I will do as suggested above.

Cheers,
Prabhakar