linux-kernel - Re: [PATCH v7 03/24] RISC-V: Add defines for the SBI message proxy extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9=C2VxhC6soxHtmacedbeCU=rFi84Br1RvN2uPcBKoLhRaJw@mail.gmail.com>
Date: Thu, 3 Jul 2025 10:46:33 +0530
From: Anup Patel <apatel@...tanamicro.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jassi Brar <jassisinghbrar@...il.com>, Thomas Gleixner <tglx@...utronix.de>, 
	"Rafael J . Wysocki" <rafael@...nel.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Alexandre Ghiti <alex@...ti.fr>, Len Brown <lenb@...nel.org>, Sunil V L <sunilvl@...tanamicro.com>, 
	Rahul Pathak <rpathak@...tanamicro.com>, Leyfoon Tan <leyfoon.tan@...rfivetech.com>, 
	Atish Patra <atish.patra@...ux.dev>, Andrew Jones <ajones@...tanamicro.com>, 
	Samuel Holland <samuel.holland@...ive.com>, Anup Patel <anup@...infault.org>, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-acpi@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Atish Patra <atishp@...osinc.com>
Subject: Re: [PATCH v7 03/24] RISC-V: Add defines for the SBI message proxy extension

On Wed, Jul 2, 2025 at 5:37 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Wed, Jul 02, 2025 at 10:43:24AM +0530, Anup Patel wrote:
> > Add defines for the new SBI message proxy extension which is part
> > of the SBI v3.0 specification.
>
> Actually a few nit-picks.
>
> ...
>
> > +enum sbi_ext_mpxy_fid {
> > +     SBI_EXT_MPXY_GET_SHMEM_SIZE,
> > +     SBI_EXT_MPXY_SET_SHMEM,
> > +     SBI_EXT_MPXY_GET_CHANNEL_IDS,
> > +     SBI_EXT_MPXY_READ_ATTRS,
> > +     SBI_EXT_MPXY_WRITE_ATTRS,
> > +     SBI_EXT_MPXY_SEND_MSG_WITH_RESP,
> > +     SBI_EXT_MPXY_SEND_MSG_WITHOUT_RESP,
> > +     SBI_EXT_MPXY_GET_NOTIFICATION_EVENTS
>
> Add a trailing comma.

Okay, I will update.

>
> > +};
>
> ...
>
> > +/* Possible values of MSG_PROT_ID attribute */
> > +enum sbi_mpxy_msgproto_id {
> > +     SBI_MPXY_MSGPROTO_RPMI_ID = 0x0
>
> Add a trailing comma, and you might want to drop 0x. I don't know what else can
> be here, esp. in the future, but some kind of the description of this in TRM
> can shed a light on what is better pattern to use.

Sure, I will update.

Regards,
Anup