lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e4bea8cb-1367-45ab-aae8-e29efbdbd082@infradead.org>
Date: Wed, 2 Jul 2025 23:06:42 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,
 Jonathan Corbet <corbet@....net>
Cc: kernel@...labora.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: document linked lists



On 7/2/25 10:48 PM, Bagas Sanjaya wrote:
> On 7/3/25 11:16, Randy Dunlap wrote:
>>
>>
>> On 7/2/25 8:24 PM, Bagas Sanjaya wrote:
>>> On Wed, Jul 02, 2025 at 10:24:47PM +0200, Nicolas Frattaroli wrote:
>>>> diff --git a/Documentation/core-api/list.rst b/Documentation/core-api/list.rst
>>>> new file mode 100644
>>>> index 0000000000000000000000000000000000000000..b0586056abb04d2bcc4518f7238ff9a94d3dd774
>>>> --- /dev/null
>>>> +++ b/Documentation/core-api/list.rst
>>>> @@ -0,0 +1,847 @@
>>
>> [snip]
>>
>>>
>>> The text LGTM, thanks!
>>>
>>> Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>
>>>
>>
>> Please see https://people.kernel.org/tglx/notes-about-netiquette,
>> especially "Trim replies".
>>
> 
> I did quote the whole diff to provide review context...
> 

If you had commented on any specific lines in the patch, then that would
be necessary. Even if you were commenting on only a few lines of the patch,
most of the patch lines could be snipped out.

The Subject: gives us the review context. It's pointless & annoying to other readers
to have to scroll down thru an 847-line patch to see any kind of Tagged-by: reply.

thanks.
-- 
~Randy


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ