lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e3a974d1f7fd1ed2a631d3ddf46eceec3a386615.camel@linaro.org>
Date: Thu, 03 Jul 2025 07:28:22 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Christian Brauner <brauner@...nel.org>
Cc: Song Liu <song@...nel.org>, bpf@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-security-module@...r.kernel.org, kernel-team@...a.com,
 andrii@...nel.org, 	eddyz87@...il.com, ast@...nel.org,
 daniel@...earbox.net, martin.lau@...ux.dev, 	viro@...iv.linux.org.uk,
 jack@...e.cz, kpsingh@...nel.org, 	mattbobrowski@...gle.com,
 amir73il@...il.com, gregkh@...uxfoundation.org, 	tj@...nel.org,
 daan.j.demeyer@...il.com, Will McVicker <willmcvicker@...gle.com>,  Peter
 Griffin <peter.griffin@...aro.org>, Tudor Ambarus
 <tudor.ambarus@...aro.org>, kernel-team@...roid.com
Subject: Re: [PATCH v3 bpf-next 1/4] kernfs: remove iattr_mutex

On Wed, 2025-07-02 at 14:17 +0200, Christian Brauner wrote:
> I'm folding:
> 
> diff --git a/fs/kernfs/inode.c b/fs/kernfs/inode.c
> index 3c293a5a21b1..457f91c412d4 100644
> --- a/fs/kernfs/inode.c
> +++ b/fs/kernfs/inode.c
> @@ -142,9 +142,9 @@ ssize_t kernfs_iop_listxattr(struct dentry *dentry, char *buf, size_t size)
>         struct kernfs_node *kn = kernfs_dentry_node(dentry);
>         struct kernfs_iattrs *attrs;
> 
> -       attrs = kernfs_iattrs_noalloc(kn);
> +       attrs = kernfs_iattrs(kn);
>         if (!attrs)
> -               return -ENODATA;
> +               return -ENOMEM;
> 
>         return simple_xattr_list(d_inode(dentry), &attrs->xattrs, buf, size);
>  }
> 
> which brings it back to the old behavior.

Yes, that makes sense and works for me too.

Thanks Christian!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ