linux-kernel - Re: [PATCH v5 04/10] dt-bindings: gpio: cdns: add Axiado AX3000 GPIO variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <080320eb-0ff0-41cd-833c-62b4738c869a@kernel.org>
Date: Thu, 3 Jul 2025 08:41:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harshit Shah <hshah@...ado.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Arnd Bergmann <arnd@...db.de>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Jan Kotas <jank@...ence.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>,
 Michal Simek <michal.simek@....com>, Przemysław Gaj
 <pgaj@...ence.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Frank Li <Frank.Li@....com>, Boris Brezillon <bbrezillon@...nel.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
 soc@...ts.linux.dev, linux-serial@...r.kernel.org,
 linux-i3c@...ts.infradead.org
Subject: Re: [PATCH v5 04/10] dt-bindings: gpio: cdns: add Axiado AX3000 GPIO
 variant

On 03/07/2025 02:22, Harshit Shah wrote:
> Add binding for Axiado AX3000 GPIO controller. So far, no changes
> are known, so it can fallback to default compatible.
> 
> Signed-off-by: Harshit Shah <hshah@...ado.com>
> ---
>  Documentation/devicetree/bindings/gpio/cdns,gpio.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> index f1a64c17366500cb0e02a0ca90da691fd992fe7d..ba55890d34bb41e14c3e8afde74111291e40ba7b 100644
> --- a/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/cdns,gpio.yaml
> @@ -11,8 +11,12 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: cdns,gpio-r1p02
> -

Why? The blank space is the style we prefer, as visible in every binding.

> +    oneOf:
> +      - const: cdns,gpio-r1p02
> +      - items:
> +          - enum:
> +              - axiado,ax3000-gpio
> +          - const: cdns,gpio-r1p02
>    reg:

Best regards,
Krzysztof