linux-kernel - Re: [PATCH V1 3/9] dt-bindings: power: Add AMD Versal power domain bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f4f68af-7b24-480f-8dae-372098b437fc@kernel.org>
Date: Thu, 3 Jul 2025 08:43:46 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gregory Williams <gregory.williams@....com>, ogabbay@...nel.org,
 michal.simek@....com, robh@...nel.org
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 3/9] dt-bindings: power: Add AMD Versal power domain
 bindings

On 02/07/2025 17:56, Gregory Williams wrote:
> Define Versal power domain value macros.
> 
> Signed-off-by: Gregory Williams <gregory.williams@....com>
> ---
>  include/dt-bindings/power/xlnx-versal-power.h | 55 +++++++++++++++++++

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

>  1 file changed, 55 insertions(+)
>  create mode 100644 include/dt-bindings/power/xlnx-versal-power.h
> 
> diff --git a/include/dt-bindings/power/xlnx-versal-power.h b/include/dt-bindings/power/xlnx-versal-power.h
> new file mode 100644
> index 000000000000..effbc70e5a12
> --- /dev/null
> +++ b/include/dt-bindings/power/xlnx-versal-power.h
> @@ -0,0 +1,55 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) */
> +/*
> + *  Copyright (C) 2019 - 2021 Xilinx, Inc.
> + *  Copyright (C) 2024 Advanced Micro Devices, Inc.
> + */
> +
> +#ifndef _DT_BINDINGS_VERSAL_POWER_H
> +#define _DT_BINDINGS_VERSAL_POWER_H
> +
> +#define PM_DEV_RPU0_0				(0x18110005U)
> +#define PM_DEV_RPU0_1				(0x18110006U)

Bindings ID start from 0 or 1 and are decimal numbers. None of these are
bindings (and commit msg does not explain here anything).

Also, where is the compatible using these? Why is this a separate patch?

Best regards,
Krzysztof