linux-kernel - Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for new RP configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62a70894-13f6-4057-bd03-d26ce0506f49@kernel.org>
Date: Thu, 3 Jul 2025 08:55:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manikandan Karunakaran Pillai <mpillai@...ence.com>,
 Hans Zhang <hans.zhang@...tech.com>
Cc: "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "lpieralisi@...nel.org" <lpieralisi@...nel.org>, "kw@...ux.com"
 <kw@...ux.com>, "mani@...nel.org" <mani@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "kwilczynski@...nel.org" <kwilczynski@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "fugang.duan@...tech.com" <fugang.duan@...tech.com>,
 "guoyin.chen@...tech.com" <guoyin.chen@...tech.com>,
 "peter.chen@...tech.com" <peter.chen@...tech.com>,
 "cix-kernel-upstream@...tech.com" <cix-kernel-upstream@...tech.com>,
 "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 01/14] dt-bindings: pci: cadence: Extend compatible for
 new RP configuration

On 03/07/2025 03:35, Manikandan Karunakaran Pillai wrote:

>>> Hi Kryzsztof,
>>>
>>> Are you suggesting to create new file for both RC and EP for HPA host like:
>>> cdns,cdns-pcie-hpa-host.yaml
>>> cdns,cdns-pcie-hpa-ep.yaml
>>> And during the commit log, explain why you need to create a new file for
>> HPA, and not use the legacy one.
>>
>> No, there was no such suggestions in any previous or current
>> discussions. IIRC, this was simply rejected previously. I consider this
>> rejected still, with the same arguments: you should use specific SoC
>> compatibles. The generic compatible alone is rather legacy approach and
>> we have been commenting on this sooooo many times.
>>
> 
> Hi Kryzsztof,
> 
> Thanks for your response. 
> The SoC specific dts patches are already being submitted by CIX team for their SoC based on the same PCIe controller IP. 

There is a SoC, otherwise why is this attached to completely unrelated
patches?

> 
> Since there is no SoC for this platform(it only an FPGA based board),
> are you suggesting to drop the dt-bindings patch altogether as the SoC specific dts bindings are already being in the same patch set.

I have impression I discussed it... either in this thread or other. I am
fine with adding compatible for your virtual setup / FPGA platform, but
this has to reflect that case. Otherwise everyone will use this one
here, just like it happened with other cdns cores.



Best regards,
Krzysztof