linux-kernel - [PATCH] staging: gpib: lpvo_usb_gpib: Remove unreachable return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250703070542.1957371-1-harshit.m.mogalapalli@oracle.com>
Date: Thu,  3 Jul 2025 00:05:30 -0700
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Dave Penkler <dpenkler@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Rubin <matchstick@...erthere.org>,
        Gaston Gonzalez <gascoar@...il.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Paul Retourné <paul.retourne@...nge.fr>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, error27@...il.com,
        harshit.m.mogalapalli@...cle.com
Subject: [PATCH] staging: gpib: lpvo_usb_gpib: Remove unreachable return statement

usb_gpib_read() has a return statement after if else which is
unreachable, clean this up.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
---
This is detected by Smatch
---
 drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 3cf5037c0cd2..dd68c4843490 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -791,7 +791,6 @@ static int usb_gpib_read(struct gpib_board *board,
 			return -EIO;
 		else
 			return -ETIME;
-		return 0;
 	}
 
 	/* allocate buffer for multibyte read */
-- 
2.39.3