linux-kernel - Re: [PATCH V3 1/2] dt-bindings: leds: pwm: Add enable-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <144df658-262f-423b-b099-8e36679ae761@kernel.org>
Date: Thu, 3 Jul 2025 09:10:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>, lee@...nel.org,
 pavel@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH V3 1/2] dt-bindings: leds: pwm: Add enable-gpios property

On 03/07/2025 05:52, LI Qingwu wrote:
> Some PWM LED chips have a dedicated enable GPIO.
> This commit adds the support to specify such GPIO.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

"Add a dedicated enable GPIO, because some PWM LED chips (e.g. foo bar
models from baz boo) ..."

Give us concrete, verifiable example where this is present. You can also
upstream your DTS as a proof, works for me.

Best regards,
Krzysztof