linux-kernel - Re: [PATCH v2] dt-bindings: iio: pressure: add invensense,icp10100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250703-rational-laughing-hedgehog-cc0eec@krzk-bin>
Date: Thu, 3 Jul 2025 09:38:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com, 
	andy@...nel.org, conor+dt@...nel.org, krzk+dt@...nel.org, robh@...nel.org, 
	jean-baptiste.maneyrol@....com, ~lkcamp/patches@...ts.sr.ht, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: pressure: add invensense,icp10100

On Tue, Jul 01, 2025 at 07:05:43PM -0300, Rodrigo Gobbi wrote:
> +$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: InvenSense ICP-101xx Barometric Pressure Sensors
> +
> +maintainers:
> +  - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
> +
> +description: |
> +  Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.

The problem with title and description here is that they do not match
compatible. oneOf:

1. Your statement is correct, but then compatibles are incomplete and
will encourage people to use incomplete compatibles for e.g. ICP-10111.
2. Compatible is correct but your statement is not correct, so then fix
the statement - drop other devices.

Assuming 1 is closer to truth, then I suggest to express it with
documenting these compatibles and using invensense,icp10100 as fallback.

Best regards,
Krzysztof