linux-kernel - Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250703-naughty-diligent-nightingale-d2fa9f@krzk-bin>
Date: Thu, 3 Jul 2025 09:49:37 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Rob Herring <robh@...nel.org>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>, sophgo@...ts.linux.dev, 
	Jingbao Qiu <qiujingbao.dlmu@...il.com>, Alexander Sverdlin <alexander.sverdlin@...il.com>, 
	linux-rtc@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory

On Wed, Jun 18, 2025 at 07:18:32AM +0800, Inochi Amaoto wrote:
> On Tue, Jun 17, 2025 at 08:09:24AM -0500, Rob Herring wrote:
> > On Mon, Jun 09, 2025 at 06:49:38AM +0800, Inochi Amaoto wrote:
> > > On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> > > > The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> > > > path 'soc'. However, the correct place for RTC bindings (even if it's
> > > > also a "syscon") is the rtc directory, so move the binding there while
> > > > fixing the $id value.
> > > > 
> > > > Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> > > > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > > > ---
> > > >  .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml        | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >  rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > similarity index 96%
> > > > rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > > rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > index 5cf186c396c9..c695d2ff9fcc 100644
> > > > --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > @@ -1,7 +1,7 @@
> > > >  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > >  %YAML 1.2
> > > >  ---
> > > > -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> > > > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> > > >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > >  
> > > >  title: Real Time Clock of the Sophgo CV1800 SoC
> > > > -- 
> > > > 2.47.2
> > > > 
> > > 
> > > As the rtc syscon has a sub function for remoteproc, is it proper to
> > > move this binding into rtc subsystem?
> > 
> > Does that affect the binding (is there more to add)? Looks like an RTC 
> > from the binding.
> > 
> 
> I think at least "resets" property may be added for the this, but I am
> not sure whether there will be more.

Just post complete bindings - see writing bindings...

Best regards,
Krzysztof