lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250703075037.2558549-3-catalin.popescu@leica-geosystems.com>
Date: Thu,  3 Jul 2025 09:50:37 +0200
From: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
To: lgirdwood@...il.com,
	broonie@...nel.org,
	robh@...nel.org,
	krzk+dt@...nel.org,
	conor+dt@...nel.org,
	shenghao-ding@...com,
	kevin-lu@...com,
	baojun.xu@...com,
	perex@...ex.cz,
	tiwai@...e.com,
	matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com
Cc: linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	m.felsch@...gutronix.de,
	bsp-development.geo@...ca-geosystems.com,
	Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Subject: [PATCH next 3/3] dts: arm64: mediatek: mt8188: fix audio amplifier reset polarity

A few MT8188 boards defines a wrong polarity for the audio amplifier's
(TAS2563/2781) reset gpio. This is due to the driver assuming a wrong
polarity so the devicetrees have to configure a wrong polarity for the
audio amplifier to be working. Now, that the driver has been fixed, we
can configure the correct polarity in the devicetrees.

Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
---
 arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dts | 2 +-
 arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dts | 2 +-
 arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dts | 2 +-
 arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dts | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dts b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dts
index ea953d7e1543..65993d25a3b0 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dts
@@ -21,7 +21,7 @@ &i2c0 {
 	tas2563: amplifier@4f {
 		compatible = "ti,tas2563", "ti,tas2781";
 		reg = <0x4f>, <0x4c>; /* left / right channel */
-		reset-gpios = <&pio 118 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&pio 118 GPIO_ACTIVE_LOW>;
 		#sound-dai-cells = <0>;
 	};
 };
diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dts b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dts
index bf87201ccf27..303d8cc3af69 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dts
@@ -33,7 +33,7 @@ es8326: audio-codec@19 {
 	tas2563: amplifier@4f {
 		compatible = "ti,tas2563", "ti,tas2781";
 		reg = <0x4f>, <0x4c>; /* left / right channel */
-		reset-gpios = <&pio 118 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&pio 118 GPIO_ACTIVE_LOW>;
 		#sound-dai-cells = <0>;
 	};
 };
diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dts b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dts
index 17d7359dfb6a..f54b116eab1a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dts
@@ -33,7 +33,7 @@ es8326: audio-codec@19 {
 	tas2563: amplifier@4f {
 		compatible = "ti,tas2563", "ti,tas2781";
 		reg = <0x4f>, <0x4c>; /* left / right channel */
-		reset-gpios = <&pio 118 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&pio 118 GPIO_ACTIVE_LOW>;
 		#sound-dai-cells = <0>;
 	};
 };
diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dts b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dts
index 825015b452d5..36c3b236dcb9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dts
@@ -21,7 +21,7 @@ &i2c0 {
 	tas2563: amplifier@4f {
 		compatible = "ti,tas2563", "ti,tas2781";
 		reg = <0x4f>, <0x4c>; /* left / right channel */
-		reset-gpios = <&pio 118 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&pio 118 GPIO_ACTIVE_LOW>;
 		#sound-dai-cells = <0>;
 	};
 };
-- 
2.43.0


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ