linux-kernel - Aw: Re: [PATCH v7 02/14] dt-bindings: net: mediatek,net: update for mt7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-112cc1ce-74d3-4fd8-a800-e302916dde33-1751529104009@trinity-msg-rest-gmx-gmx-live-847b5f5c86-wpb8f>
Date: Thu, 3 Jul 2025 07:51:44 +0000
From: frank-w@...lic-files.de
To: krzk@...nel.org, linux@...web.de
Cc: myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
 cw00.choi@...sung.com, djakov@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, andrew@...n.ch, olteanv@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, johnson.wang@...iatek.com,
 arinc.unal@...nc9.com, Landen.Chao@...iatek.com, dqfext@...il.com,
 sean.wang@...iatek.com, daniel@...rotopia.org, lorenzo@...nel.org,
 nbd@....name, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Aw: Re: [PATCH v7 02/14] dt-bindings: net: mediatek,net: update for
 mt7988

> Gesendet: Mittwoch, 2. Juli 2025 um 08:29
> Von: "Krzysztof Kozlowski" <krzk@...nel.org>
> Betreff: Re: [PATCH v7 02/14] dt-bindings: net: mediatek,net: update for mt7988
>
> On 01/07/2025 12:33, Frank Wunderlich wrote:
> > Am 1. Juli 2025 08:41:42 MESZ schrieb Krzysztof Kozlowski <krzk@...nel.org>:
> >> On Sat, Jun 28, 2025 at 06:54:37PM +0200, Frank Wunderlich wrote:
> >>> From: Frank Wunderlich <frank-w@...lic-files.de>
> >>>
> >>> Update binding for mt7988 which has 3 gmac and a sram for dma
> >>> operations.
> >>
> >> I asked why you are updating. You claim you update because it has 3
> >> GMAC... but that's irrelevant, because it is easy to answer with: it did
> >> not have 3 GMAC before?
> >>
> >> So same question: Provide real reason why you are making updates. That's
> >> why you have commit msg.
> > 
> > MT7988 had always 3 gmac,but no dts with ethernet
> > node till now.
> > As i try to upstream the dts,i fell over this.
> 
> What does it mean? Are you adding new device or not? Nothing explains
> that something was missing.

The binding already exists, but was incomplete. It was added while changing ethernet driver but was not used
because i'm the first person adding mt7988 Ethernet node to devicetree in this series.

> > 
> > Imho changing the regex for the mac subnodes was
> > simply forgotten to be updated on initial mt7988
> > support patch.
> 
> Fix
> your
> wrapping because
> it is
> difficult
> to follow
> such
> style.

i understand that it is not the best, but i have to manually wrap lines because neither my webmail nor
my Android Mail-App (K9Mail) supports automatic wrapping (created a feature-request some years ago which
got rejected). I try to wrap it as good as possible, but still manually (on phone it is not that easy).

> > 
> > I try to rephrase it like this:
> > 
> > Binding was not aware for 3 MAC subnodes because
> > previous mediatek SoC had only 2. Change this to allow
> > 3 GMAC in mt7988 devicetree.
> 
> So a fix for existing? Than add Fixes tag, describe the issue and fix
> ONLY that issue.

Yes, binding for mt7988 already exists withing the mediatek,net binding, but the pattern for mac subnodes
was not updated while adding. So i had to do it before adding the ethernet node to dts in same series.

But yes, i can separate this change again and add Fixes Tag. So just the sram-Property is added in this patch
and i repharse it like this.

> Best regards,
> Krzysztof

regards Frank