[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50eda97d-7a21-4ac0-bdff-1012ef273b62@arm.com>
Date: Thu, 3 Jul 2025 13:29:32 +0530
From: Dev Jain <dev.jain@....com>
To: Aboorva Devarajan <aboorvad@...ux.ibm.com>, akpm@...ux-foundation.org,
Liam.Howlett@...cle.com, lorenzo.stoakes@...cle.com, shuah@...nel.org,
pfalcato@...e.de, david@...hat.com, ziy@...dia.com,
baolin.wang@...ux.alibaba.com, npache@...hat.com, ryan.roberts@....com,
baohua@...nel.org
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org, donettom@...ux.ibm.com, ritesh.list@...il.com
Subject: Re: [PATCH v2 1/7] mm/selftests: Fix incorrect pointer being passed
to mark_range()
On 03/07/25 11:36 am, Aboorva Devarajan wrote:
> From: Donet Tom <donettom@...ux.ibm.com>
>
> In main(), the high address is stored in hptr, but for mark_range(),
> the address passed is ptr, not hptr. Fixed this by changing ptr[i] to
> hptr[i] in mark_range() function call.
>
> Fixes: b2a79f62133a ("selftests/mm: virtual_address_range: unmap chunks after validation")
> Signed-off-by: Donet Tom <donettom@...ux.ibm.com>
> Signed-off-by: Aboorva Devarajan <aboorvad@...ux.ibm.com>
> ---
> tools/testing/selftests/mm/virtual_address_range.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c
> index 169dbd692bf5..e24c36a39f22 100644
> --- a/tools/testing/selftests/mm/virtual_address_range.c
> +++ b/tools/testing/selftests/mm/virtual_address_range.c
> @@ -227,7 +227,7 @@ int main(int argc, char *argv[])
> if (hptr[i] == MAP_FAILED)
> break;
>
> - mark_range(ptr[i], MAP_CHUNK_SIZE);
> + mark_range(hptr[i], MAP_CHUNK_SIZE);
> validate_addr(hptr[i], 1);
> }
> hchunks = i;
Makes sense.
Reviewed-by: Dev Jain <dev.jain@....com>
Powered by blists - more mailing lists