linux-kernel - [tip: sched/core] rust: sync: Mark PollCondVar::drop() inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175153177030.406.10410426934366776743.tip-bot2@tip-bot2>
Date: Thu, 03 Jul 2025 08:36:10 -0000
From: "tip-bot2 for Kunwu Chan" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Alice Ryhl <aliceryhl@...gle.com>, Grace Deng <Grace.Deng006@...il.com>,
 Kunwu Chan <kunwu.chan@...mail.com>, Benno Lossin <benno.lossin@...ton.me>,
 Boqun Feng <boqun.feng@...il.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject: [tip: sched/core] rust: sync: Mark PollCondVar::drop() inline

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     11867144ff81ab98f4b11c99716c3e8b714b8755
Gitweb:        https://git.kernel.org/tip/11867144ff81ab98f4b11c99716c3e8b714b8755
Author:        Kunwu Chan <kunwu.chan@...mail.com>
AuthorDate:    Mon, 17 Mar 2025 10:52:05 +08:00
Committer:     Boqun Feng <boqun.feng@...il.com>
CommitterDate: Tue, 24 Jun 2025 10:23:48 -07:00

rust: sync: Mark PollCondVar::drop() inline

When building the kernel using the llvm-18.1.3-rust-1.85.0-x86_64
with ARCH=arm64, the following symbols are generated:

$nm vmlinux | grep ' _R'.*PollCondVar  | rustfilt
... T <kernel::sync::poll::PollCondVar as kernel::init::PinnedDrop>::drop
...

This Rust symbol is trivial wrappers around the C functions
__wake_up_pollfree() and synchronize_rcu(). It doesn't make sense to go
through a trivial wrapper for its functions, so mark it inline.

[boqun: Reword the commit title and re-format the commit log per tip
tree's requirement, remove unnecessary information from "nm vmlinux"
result.]

Link: https://github.com/Rust-for-Linux/linux/issues/1145
Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
Co-developed-by: Grace Deng <Grace.Deng006@...il.com>
Signed-off-by: Grace Deng <Grace.Deng006@...il.com>
Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>
Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
Reviewed-by: Benno Lossin <benno.lossin@...ton.me>
Signed-off-by: Boqun Feng <boqun.feng@...il.com>
Link: https://lore.kernel.org/r/20250317025205.2366518-1-kunwu.chan@linux.dev
---
 rust/kernel/sync/poll.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rust/kernel/sync/poll.rs b/rust/kernel/sync/poll.rs
index d7e6e59..7b973d7 100644
--- a/rust/kernel/sync/poll.rs
+++ b/rust/kernel/sync/poll.rs
@@ -107,6 +107,7 @@ impl Deref for PollCondVar {
 
 #[pinned_drop]
 impl PinnedDrop for PollCondVar {
+    #[inline]
     fn drop(self: Pin<&mut Self>) {
         // Clear anything registered using `register_wait`.
         //