linux-kernel - Re: [PATCH v2] docs: document linked lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGXeyqygzKi2P-kP@archie.me>
Date: Thu, 3 Jul 2025 08:37:14 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,
	Jonathan Corbet <corbet@....net>
Cc: Randy Dunlap <rdunlap@...radead.org>, kernel@...labora.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: document linked lists

On Wed, Jul 02, 2025 at 10:24:47PM +0200, Nicolas Frattaroli wrote:
> +In State 2, we've added Grock after the list head::
> +
> +         .--------------------.
> +         v                    |
> +    .--------.     .-------.  |
> +    | clowns |---->| Grock |--'
> +    '--------'     '-------'

Looks like the corners are a bit imbalanced (single quotes are taller than
dots). What about using plus instead? Like:

---- >8 ----
diff --git a/Documentation/core-api/list.rst b/Documentation/core-api/list.rst
index b0586056abb04d..bf92f44d7b2d06 100644
--- a/Documentation/core-api/list.rst
+++ b/Documentation/core-api/list.rst
@@ -148,11 +148,11 @@ clarity.
 
 In State 2, we've added Grock after the list head::
 
-         .--------------------.
+         +--------------------+
          v                    |
-    .--------.     .-------.  |
-    | clowns |---->| Grock |--'
-    '--------'     '-------'
+    +--------+     +-------+  |
+    | clowns |---->| Grock |--+
+    +--------+     +-------+
 
 This diagram shows the "clowns" node pointing at a new node labeled "Grock".
 The Grock node is pointing back at the "clowns" node.

The docs wording looks good, though.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)