linux-kernel - Re: [PATCH net-next v3 5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <184eb232eceb01f8.c7773f00732f7e87.4136a253a628cb2b@Jude-Air.local>
Date: Thu, 3 Jul 2025 09:00:36 +0000
From: "Junhui Liu" <junhui.liu@...moral.tech>
To: "Vivian Wang" <wangruikang@...as.ac.cn>, 
	"Andrew Lunn" <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, 
	"Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, 
	"Paolo Abeni" <pabeni@...hat.com>, "Rob Herring" <robh@...nel.org>, 
	"Krzysztof Kozlowski" <krzk+dt@...nel.org>, 
	"Conor Dooley" <conor+dt@...nel.org>, "Yixun Lan" <dlan@...too.org>, 
	"Philipp Zabel" <p.zabel@...gutronix.de>, 
	"Paul Walmsley" <paul.walmsley@...ive.com>, 
	"Palmer Dabbelt" <palmer@...belt.com>, "Albert Ou" <aou@...s.berkeley.edu>, 
	"Alexandre Ghiti" <alex@...ti.fr>
Cc: "Vivian Wang" <uwu@...m.page>, 
	"Lukas Bulwahn" <lukas.bulwahn@...hat.com>, 
	"Geert Uytterhoeven" <geert+renesas@...der.be>, 
	"Parthiban Veerasooran" <Parthiban.Veerasooran@...rochip.com>, 
	<netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, 
	<linux-riscv@...ts.infradead.org>, <spacemit@...ts.linux.dev>, 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 5/5] riscv: dts: spacemit: Add Ethernet support
	 for Jupiter

Hi Vivian,

On 03/07/2025 15:46, Vivian Wang wrote:
> Hi Junhui,
> 
> On 7/3/25 14:48, Junhui Liu wrote:
>> Hi Vivian,
>> Thanks for you work!
>>
>> On 2025/7/2 14:01, Vivian Wang wrote:
>>> Milk-V Jupiter uses an RGMII PHY for each port and uses GPIO for PHY
>>> reset.
>>>
>>> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
>>
>> Successfully tested with iperf3 on Milk-V Jupiter.
>>
>> TCP Rx: 941 Mbits/sec
>> TCP Tx: 943 Mbits/sec
>> UDP Rx: 956 Mbits/sec
>> UDP Tx: 956 Mbits/sec
>>
>> Tested-by: Junhui Liu <junhui.liu@...moral.tech> 
>>
> Thanks for the testing! I do not have a Milk-V Jupiter handy, so that
> was very helpful.
> 
> As discussed [1], I will post a v4 soon with minor fixes and also sans
> the DTS changes. I will put your Tested-by on the driver patch instead
> of this DTS patch, so it will show up in v4.
> 
> Are you okay with this? If you don't like it feel free to tell me.

It's okay to me. Thanks!

> 
> Regards,
> Vivian "dramforever" Wang
> 
> [1]: https://lore.kernel.org/spacemit/a9cad07c-0973-43c3-89f3-95b856b575df@iscas.ac.cn/
> 
>>> ---
>>>   arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts | 46
>>> +++++++++++++++++++++++
>>>   1 file changed, 46 insertions(+)
>>>
>>> diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
>>> b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
>>> index
>>> 4483192141049caa201c093fb206b6134a064f42..c5933555c06b66f40e61fe2b9c159ba0770c2fa1
>>> 100644
>>> --- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
>>> +++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
>>> @@ -20,6 +20,52 @@ chosen {
>>>       };
>>>   };
>>>   +&eth0 {
>>> +    phy-handle = <&rgmii0>;
>>> +    phy-mode = "rgmii-id";
>>> +    pinctrl-names = "default";
>>> +    pinctrl-0 = <&gmac0_cfg>;
>>> +    rx-internal-delay-ps = <0>;
>>> +    tx-internal-delay-ps = <0>;
>>> +    status = "okay";
>>> +
>>> +    mdio-bus {
>>> +        #address-cells = <0x1>;
>>> +        #size-cells = <0x0>;
>>> +
>>> +        reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>;
>>> +        reset-delay-us = <10000>;
>>> +        reset-post-delay-us = <100000>;
>>> +
>>> +        rgmii0: phy@1 {
>>> +            reg = <0x1>;
>>> +        };
>>> +    };
>>> +};
>>> +
>>> +&eth1 {
>>> +    phy-handle = <&rgmii1>;
>>> +    phy-mode = "rgmii-id";
>>> +    pinctrl-names = "default";
>>> +    pinctrl-0 = <&gmac1_cfg>;
>>> +    rx-internal-delay-ps = <0>;
>>> +    tx-internal-delay-ps = <250>;
>>> +    status = "okay";
>>> +
>>> +    mdio-bus {
>>> +        #address-cells = <0x1>;
>>> +        #size-cells = <0x0>;
>>> +
>>> +        reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>;
>>> +        reset-delay-us = <10000>;
>>> +        reset-post-delay-us = <100000>;
>>> +
>>> +        rgmii1: phy@1 {
>>> +            reg = <0x1>;
>>> +        };
>>> +    };
>>> +};
>>> +
>>>   &uart0 {
>>>       pinctrl-names = "default";
>>>       pinctrl-0 = <&uart0_2_cfg>;
>>>

-- 
Best regards,
Junhui Liu