linux-kernel - Re: [PATCH v2 1/3] nvme: add capability to connect to an admin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250703090406.GB4757@lst.de>
Date: Thu, 3 Jul 2025 11:04:06 +0200
From: hch <hch@....de>
To: Kamaljit Singh <Kamaljit.Singh1@....com>
Cc: Damien Le Moal <dlemoal@...nel.org>,
	"kbusch@...nel.org" <kbusch@...nel.org>,
	"axboe@...nel.dk" <axboe@...nel.dk>, hch <hch@....de>,
	"sagi@...mberg.me" <sagi@...mberg.me>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cassel@...nel.org" <cassel@...nel.org>
Subject: Re: [PATCH v2 1/3] nvme: add capability to connect to an admin
 controller

On Wed, Jul 02, 2025 at 06:39:09PM +0000, Kamaljit Singh wrote:
> >call this in all fabrics drivers.
> Like I mentioned in response for 3/3, this can affect other drivers like apple/fc
> and I don't have any way of testing them. If you're okay with that, I can move
> nvme_override_prohibited_io_queues() into nvme_init_subsystem(). I did some
> analysis and nvme_init_subsystem() seems to be covering reconnects as well.

This should go into generic code.  Apple does not support admin controllers.
FC should, and this does the right thing for them.

> >> @@ -3215,6 +3231,11 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
> >>               kfree(subsys);
> >>               return -EINVAL;
> >>       }
> >> +     if (nvme_admin_ctrl(ctrl))
> >> +             dev_info(ctrl->device,
> >> +                     "Subsystem %s is an administrative controller",
> >> +                     subsys->subnqn);
> >
> >We do not print an equivalent message for other subsystem controller types. So
> >drop this.
> I left that msg in there for debugging purposes. I can either change it to
> dev_dbg() or if that's still not likeable/cluttering, I can remove it.
> Please let me know.

I'd leave this as dev_dbg only.