linux-kernel - Re: [PATCH v4] checkpatch: Check for missing sentinels in ID arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83e65ecbcc1a6af67a432a20d2a40bd80b945ee0.camel@perches.com>
Date: Thu, 03 Jul 2025 02:14:39 -0700
From: Joe Perches <joe@...ches.com>
To: Brian Norris <briannorris@...omium.org>, Andy Whitcroft
 <apw@...onical.com>,  Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Dwaipayan Ray <dwaipayanray1@...il.com>, 
 Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH v4] checkpatch: Check for missing sentinels in ID arrays

On Wed, 2025-07-02 at 16:52 -0700, Brian Norris wrote:
> All of the ID tables based on <linux/mod_devicetable.h> (of_device_id,
> pci_device_id, ...) require their arrays to end in an empty sentinel
> value. That's usually spelled with an empty initializer entry (e.g.,
> "{}"), but also sometimes with explicit 0 entries, field initializers
> (e.g., '.id = ""'), or even a macro entry (like PCMCIA_DEVICE_NULL).
> 
> Without a sentinel, device-matching code may read out of bounds.
[]
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Acked-by: Joe Perches <joe@...ches.com>