| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMRc=Md4cq7jGOZgfnEJkXEXMu4NuJL1-r_fntuAhmCzEwfOpg@mail.gmail.com>
Date: Thu, 3 Jul 2025 11:54:22 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Shree Ramamoorthy <s-ramamoorthy@...com>
Cc: aaro.koskinen@....fi, andreas@...nade.info, khilman@...libre.com,
rogerq@...nel.org, tony@...mide.com, linus.walleij@...aro.org,
linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, m-leonard@...com, praneeth@...com,
jcormier@...ticallink.com
Subject: Re: [PATCH v5 2/2] gpio: tps65219: Add support for TI TPS65214 PMIC
On Wed, Jul 2, 2025 at 6:51 PM Shree Ramamoorthy <s-ramamoorthy@...com> wrote:
>
> Add support for the TI TPS65214 PMIC with the addition of an id_table,
> separate TPS65214 template_chip, and device-specific _change_direction
> functions.
>
> - Use platform_get_device_id() to assign dev-specific information.
> - Use different change_direction() functions since TPS65214's GPIO
> configuration bits are changeable during device operation through bit
> GPIO_CONFIG in GENERAL_CONFIG register.
> - Remove MODULE_ALIAS since it is now generated by MODULE_DEVICE_TABLE.
>
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@...com>
> ---
> drivers/gpio/gpio-tps65219.c | 93 +++++++++++++++++++++++++++++++++---
> 1 file changed, 87 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c
> index 3c762103babc..7a62d490ad0a 100644
> --- a/drivers/gpio/gpio-tps65219.c
> +++ b/drivers/gpio/gpio-tps65219.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * GPIO driver for TI TPS65215/TPS65219 PMICs
> + * GPIO driver for TI TPS65214/TPS65215/TPS65219 PMICs
> *
> * Copyright (C) 2025 Texas Instruments Incorporated - http://www.ti.com/
> */
> @@ -13,10 +13,15 @@
> #include <linux/regmap.h>
>
> #define TPS65219_GPIO0_DIR_MASK BIT(3)
> +#define TPS65214_GPIO0_DIR_MASK BIT(1)
> #define TPS6521X_GPIO0_OFFSET 2
> #define TPS6521X_GPIO0_IDX 0
>
> /*
> + * TPS65214 GPIO mapping
> + * Linux gpio offset 0 -> GPIO (pin16) -> bit_offset 2
> + * Linux gpio offset 1 -> GPO1 (pin9 ) -> bit_offset 0
> + *
> * TPS65215 & TPS65219 GPIO mapping
> * Linux gpio offset 0 -> GPIO (pin16) -> bit_offset 2
> * Linux gpio offset 1 -> GPO1 (pin8 ) -> bit_offset 0
> @@ -24,10 +29,26 @@
> */
>
> struct tps65219_gpio {
> + int (*change_dir)(struct gpio_chip *gc, unsigned int offset, unsigned int dir);
> struct gpio_chip gpio_chip;
> struct tps65219 *tps;
> };
>
> +static int tps65214_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
> +{
> + struct tps65219_gpio *gpio = gpiochip_get_data(gc);
> + int ret, val;
> +
> + if (offset != TPS6521X_GPIO0_IDX)
> + return GPIO_LINE_DIRECTION_OUT;
> +
> + ret = regmap_read(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG, &val);
> + if (ret)
> + return ret;
> +
> + return !(val & TPS65214_GPIO0_DIR_MASK);
> +}
> +
> static int tps65219_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
> {
> struct tps65219_gpio *gpio = gpiochip_get_data(gc);
> @@ -119,6 +140,34 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off
> return -ENOTSUPP;
> }
>
> +static int tps65214_gpio_change_direction(struct gpio_chip *gc, unsigned int offset,
> + unsigned int direction)
> +{
> + struct tps65219_gpio *gpio = gpiochip_get_data(gc);
> + struct device *dev = gpio->tps->dev;
> + int val, ret;
> +
> + /* Verified if GPIO or GPO in parent function
> + * Masked value: 0 = GPIO, 1 = VSEL
> + */
> + ret = regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, &val);
> + if (ret)
> + return ret;
> +
> + ret = !!(val & BIT(TPS65219_GPIO0_DIR_MASK));
> + if (ret)
> + dev_err(dev, "GPIO%d configured as VSEL, not GPIO\n", offset);
> +
> + ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG,
> + TPS65214_GPIO0_DIR_MASK, direction);
> + if (ret)
> + dev_err(dev,
> + "Fail to change direction to %u for GPIO%d.\n",
> + direction, offset);
> +
> + return ret;
> +}
> +
> static int tps65219_gpio_direction_input(struct gpio_chip *gc, unsigned int offset)
> {
> struct tps65219_gpio *gpio = gpiochip_get_data(gc);
> @@ -132,11 +181,13 @@ static int tps65219_gpio_direction_input(struct gpio_chip *gc, unsigned int offs
> if (tps65219_gpio_get_direction(gc, offset) == GPIO_LINE_DIRECTION_IN)
> return 0;
>
> - return tps65219_gpio_change_direction(gc, offset, GPIO_LINE_DIRECTION_IN);
> + return gpio->change_dir(gc, offset, GPIO_LINE_DIRECTION_IN);
> }
>
> static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, int value)
> {
> + struct tps65219_gpio *gpio = gpiochip_get_data(gc);
> +
> tps65219_gpio_set(gc, offset, value);
> if (offset != TPS6521X_GPIO0_IDX)
> return 0;
> @@ -144,9 +195,22 @@ static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int off
> if (tps65219_gpio_get_direction(gc, offset) == GPIO_LINE_DIRECTION_OUT)
> return 0;
>
> - return tps65219_gpio_change_direction(gc, offset, GPIO_LINE_DIRECTION_OUT);
> + return gpio->change_dir(gc, offset, GPIO_LINE_DIRECTION_OUT);
> }
>
> +static const struct gpio_chip tps65214_template_chip = {
> + .label = "tps65214-gpio",
> + .owner = THIS_MODULE,
> + .get_direction = tps65214_gpio_get_direction,
> + .direction_input = tps65219_gpio_direction_input,
> + .direction_output = tps65219_gpio_direction_output,
> + .get = tps65219_gpio_get,
> + .set = tps65219_gpio_set,
Please use the set_rv() variant, regular set() is deprecated and will
be removed soon.
> + .base = -1,
> + .ngpio = 2,
> + .can_sleep = true,
> +};
> +
> static const struct gpio_chip tps65219_template_chip = {
> .label = "tps65219-gpio",
> .owner = THIS_MODULE,
> @@ -162,6 +226,7 @@ static const struct gpio_chip tps65219_template_chip = {
>
> static int tps65219_gpio_probe(struct platform_device *pdev)
> {
> + enum pmic_id chip = platform_get_device_id(pdev)->driver_data;
> struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent);
> struct tps65219_gpio *gpio;
>
> @@ -169,22 +234,38 @@ static int tps65219_gpio_probe(struct platform_device *pdev)
> if (!gpio)
> return -ENOMEM;
>
> + if (chip == TPS65214) {
> + gpio->gpio_chip = tps65214_template_chip;
> + gpio->change_dir = tps65214_gpio_change_direction;
> + } else if (chip == TPS65219) {
> + gpio->gpio_chip = tps65219_template_chip;
> + gpio->change_dir = tps65219_gpio_change_direction;
> + } else {
> + return -ENODATA;
> + }
> +
> gpio->tps = tps;
> - gpio->gpio_chip = tps65219_template_chip;
> gpio->gpio_chip.parent = tps->dev;
>
> return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio);
> }
>
> +static const struct platform_device_id tps6521x_gpio_id_table[] = {
> + { "tps65214-gpio", TPS65214 },
> + { "tps65219-gpio", TPS65219 },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(platform, tps6521x_gpio_id_table);
> +
> static struct platform_driver tps65219_gpio_driver = {
> .driver = {
> .name = "tps65219-gpio",
> },
> .probe = tps65219_gpio_probe,
> + .id_table = tps6521x_gpio_id_table,
> };
> module_platform_driver(tps65219_gpio_driver);
>
> -MODULE_ALIAS("platform:tps65219-gpio");
> MODULE_AUTHOR("Jonathan Cormier <jcormier@...ticallink.com>");
> -MODULE_DESCRIPTION("TPS65215/TPS65219 GPIO driver");
> +MODULE_DESCRIPTION("TPS65214/TPS65215/TPS65219 GPIO driver");
> MODULE_LICENSE("GPL");
> --
> 2.43.0
>
>
Bartosz
Powered by blists - more mailing lists