[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250703113410.66696-1-lizhe.67@bytedance.com>
Date: Thu, 3 Jul 2025 19:34:10 +0800
From: lizhe.67@...edance.com
To: david@...hat.com
Cc: alex.williamson@...hat.com,
jgg@...dia.com,
jgg@...pe.ca,
kvm@...r.kernel.org,
linux-kernel@...r.kernel.org,
lizhe.67@...edance.com,
peterx@...hat.com
Subject: Re: [PATCH 0/4] vfio/type1: optimize vfio_pin_pages_remote() and vfio_unpin_pages_remote() for large folio
On Thu, 3 Jul 2025 13:06:26 +0200, david@...hat.com wrote:
> > +static inline unsigned long contig_pages(struct page **pages,
> > + unsigned long size)
>
> size -> nr_pages
>
> > +{
> > + struct page *first_page = pages[0];
> > + unsigned long i;
> > +
> > + for (i = 1; i < size; i++)
> > + if (pages[i] != nth_page(first_page, i))
> > + break;
> > + return i;
> > +}
>
> LGTM.
>
> I wonder if we can find a better function name, especially when moving
> this to some header where it can be reused.
>
> Something that expresses that we will return the next batch that starts
> at the first page.
Thank you. Given that this function may have more users in the future,
I will place it in include/linux/mm.h instead of the vfio file. Once
I've addressed the comments on the other patches with Jason, I will
resend a new patchset.
Thanks,
Zhe
Powered by blists - more mailing lists