linux-kernel - Re: [PATCH] ACPI: FAN: Update fps count debug print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g-bArTdntUCv=NiuBX7aDTGifYFF8Q8nhn6XmBgSKgCQ@mail.gmail.com>
Date: Thu, 3 Jul 2025 14:11:33 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: "Sumeet R.P." <sumeet4linux@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, linux-acpi@...r.kernel.org, lenb@...nel.org, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] ACPI: FAN: Update fps count debug print

On Thu, Jul 3, 2025 at 1:37 PM Sumeet R.P. <sumeet4linux@...il.com> wrote:
>
>
> On Wed, Jul 2, 2025 at 11:24 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>>
>> On Sat, Jun 21, 2025 at 7:17 AM Sumeet Pawnikar <sumeet4linux@...il.com> wrote:
>> >
>> > Update invalid value returned debug print with fps_count
>> > instead of control value for checking fan fps count condition.
>> >
>> > Signed-off-by: Sumeet Pawnikar <sumeet4linux@...il.com>
>> > ---
>> >  drivers/acpi/fan_core.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
>> > index 8ad12ad3aaaf..9f2696a1928c 100644
>> > --- a/drivers/acpi/fan_core.c
>> > +++ b/drivers/acpi/fan_core.c
>> > @@ -102,7 +102,7 @@ static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
>> >                         break;
>> >         }
>> >         if (i == fan->fps_count) {
>> > -               dev_dbg(&device->dev, "Invalid control value returned\n");
>> > +               dev_dbg(&device->dev, "Invalid fps_count value returned\n");
>>
>> I guess this should be "fps" instead of "fps_count" because the latter
>> is just the array size, isn't it?
>>
>
> Yes, this can be fps.
>
>>
>> But I don't see why it should not be "control" either.
>>
> In this same function fan_get_state_acpi4(), the same debug print message
> is already present for invalid control value.
> So, it's confusing when we get the message and difficult to identify
> due to which condition the message is coming from.

Agreed, so maybe change the second message to something like "No
matching fps control value".