linux-kernel - Re: [PATCH V2 2/2] arm64: dts: imx8mn: Configure DMA on UART2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb30270f-18a7-4fc6-8c12-05255b82c5cf@pengutronix.de>
Date: Thu, 3 Jul 2025 14:15:42 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Adam Ford <aford173@...il.com>, linux-arm-kernel@...ts.infradead.org
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 aford@...conembedded.com, linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH V2 2/2] arm64: dts: imx8mn: Configure DMA on UART2

On 7/3/25 13:38, Adam Ford wrote:
> UART2 is often used as the console, so the DMA was likely left
> off on purpose, since it's recommended to not use the DMA on the
> console. Because, the driver checks to see if the UART is used for
> the console when determining if it should initialize DMA, it
> should be safe to enable DMA on UART2 for all users.
> 
> Signed-off-by: Adam Ford <aford173@...il.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

> ---
> V2:  Fix spelling errors in commit message
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index 848ba5e46ee6..b98b3d0ddf25 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -860,6 +860,8 @@ uart2: serial@...90000 {
>  					clocks = <&clk IMX8MN_CLK_UART2_ROOT>,
>  						 <&clk IMX8MN_CLK_UART2_ROOT>;
>  					clock-names = "ipg", "per";
> +					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> +					dma-names = "rx", "tx";
>  					status = "disabled";
>  				};
>  			};

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |