linux-kernel - Re: [PATCH] mmc: sdhci: Quirk for broken command queuing on Intel GLK-based Positivo models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrLBV=AwDTiSC14N+qBknU+zM7bK-Vtj4a=c+byiUOgZA@mail.gmail.com>
Date: Thu, 3 Jul 2025 14:19:23 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: edson drosdeck <edson.drosdeck@...il.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci: Quirk for broken command queuing on Intel
 GLK-based Positivo models

On Wed, 2 Jul 2025 at 01:07, edson drosdeck <edson.drosdeck@...il.com> wrote:
>
> Thanks for the feedback!
>
> Just to confirm: should I resend this as v2 with the corrected subject line?

No need for that this time.

I have applied it for fixes and amended the patch according to
Adrian's suggestions, thanks!

Kind regards
Uffe


>
> Best regards,
> Edson Juliano Drosdeck
>
>
> Em qui., 26 de jun. de 2025 às 11:05, Adrian Hunter
> <adrian.hunter@...el.com> escreveu:
> >
> > On 26/06/2025 14:24, Edson Juliano Drosdeck wrote:
> > > Disable command queuing on Intel GLK-based Positivo models.
> > >
> > > Without this quirk, CQE (Command Queuing Engine) causes instability
> > > or I/O errors during operation. Disabling it ensures stable
> > > operation on affected devices.
> > >
> > > Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@...il.com>
> >
> > Subject would normally begin "mmc: sdhci-pci:" instead of "mmc: sdhci:"
> >
> > Otherwise:
> >
> > Acked-by: Adrian Hunter <adrian.hunter@...el.com>
> >
> > Also I guess:
> >
> > Fixes: bedf9fc01ff1 ("mmc: sdhci: Workaround broken command queuing on Intel GLK")
> > Cc: stable@...r.kernel.org
> >
> > > ---
> > >  drivers/mmc/host/sdhci-pci-core.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> > > index 13a84b9309e0..e3877a1c72a9 100644
> > > --- a/drivers/mmc/host/sdhci-pci-core.c
> > > +++ b/drivers/mmc/host/sdhci-pci-core.c
> > > @@ -913,7 +913,8 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
> > >  {
> > >       return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_EMMC &&
> > >              (dmi_match(DMI_BIOS_VENDOR, "LENOVO") ||
> > > -             dmi_match(DMI_SYS_VENDOR, "IRBIS"));
> > > +             dmi_match(DMI_SYS_VENDOR, "IRBIS") ||
> > > +             dmi_match(DMI_SYS_VENDOR, "Positivo Tecnologia SA"));
> > >  }
> > >
> > >  static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)
> >