linux-kernel - Re: [PATCH v3] ALSA: hda: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07369447-2b90-4174-8c77-a406cc57c055@opensource.cirrus.com>
Date: Fri, 4 Jul 2025 13:33:44 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: GalaxySnail <me@...ys.nl>, simont@...nsource.cirrus.com
Cc: david.rhodes@...rus.com, linux-kernel@...r.kernel.org,
        linux-sound@...r.kernel.org, lkp@...el.com,
        oe-kbuild-all@...ts.linux.dev, patches@...nsource.cirrus.com,
        perex@...ex.cz, tiwai@...e.com
Subject: Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56

On 24/06/2025 11:17 am, GalaxySnail wrote:
> add firmware information in the .modinfo section, so that userspace
> tools can find out firmware required by cs35l41/cs35l56 kernel module
> 
> Signed-off-by: GalaxySnail <me@...ys.nl>
> ---
> Thanks for your review!
> 
> v2 -> v3: fixed typo
> v1 -> v2: fixed missing ';' in the previous patch
> 
>   sound/pci/hda/cs35l41_hda.c | 2 ++
>   sound/pci/hda/cs35l56_hda.c | 4 ++++
>   2 files changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index d5bc81099d0d..17cdce91fdbf 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>   MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@...nsource.cirrus.com>");
>   MODULE_LICENSE("GPL");
>   MODULE_IMPORT_NS("FW_CS_DSP");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.bin");
> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index 3f2fd32f4ad9..eedd8fdd3b8b 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>   MODULE_AUTHOR("Richard Fitzgerald <rf@...nsource.cirrus.com>");
>   MODULE_AUTHOR("Simon Trimmer <simont@...nsource.cirrus.com>");
>   MODULE_LICENSE("GPL");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.bin");

Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>