linux-kernel - Re: [PATCH net-next v2 1/7] netpoll: Improve code clarity with explicit struct size calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250704135013.GO41770@horms.kernel.org>
Date: Fri, 4 Jul 2025 14:50:13 +0100
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v2 1/7] netpoll: Improve code clarity with
 explicit struct size calculations

On Wed, Jul 02, 2025 at 03:06:33AM -0700, Breno Leitao wrote:
> Replace pointer-dereference sizeof() operations with explicit struct names
> for improved readability and maintainability. This change:
> 
> 1. Replaces `sizeof(*udph)` with `sizeof(struct udphdr)`
> 2. Replaces `sizeof(*ip6h)` with `sizeof(struct ipv6hdr)`
> 3. Replaces `sizeof(*iph)` with `sizeof(struct iphdr)`
> 
> This will make it easy to move code in the upcoming patches.
> 
> No functional changes are introduced by this patch.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Simon Horman <horms@...nel.org>