linux-kernel - Re: [PATCH net-next v2 6/7] netpoll: move Ethernet setup to push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGfhG_E0Mxk8zPdB@gmail.com>
Date: Fri, 4 Jul 2025 15:11:39 +0100
From: Breno Leitao <leitao@...ian.org>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v2 6/7] netpoll: move Ethernet setup to
 push_eth() helper

On Fri, Jul 04, 2025 at 02:54:50PM +0100, Simon Horman wrote:
> On Wed, Jul 02, 2025 at 03:06:38AM -0700, Breno Leitao wrote:
> > Refactor Ethernet header population into dedicated function, completing
> > the layered abstraction with:
> > 
> > - push_eth() for link layer
> > - push_udp() for transport
> > - push_ipv4()/push_ipv6() for network
> > 
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> 
> I note that Jakub's review of v1 has been addressed here.

Thanks for the whole review, Simon. I appreciate it!

--breno