linux-kernel - Re: [PATCH net-next v2] net: replace ND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250704141904.GV41770@horms.kernel.org>
Date: Fri, 4 Jul 2025 15:19:04 +0100
From: Simon Horman <horms@...nel.org>
To: Wang Liang <wangliang74@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, alex.aring@...il.com, dsahern@...nel.org,
	yuehaibing@...wei.com, zhangchangzhong@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-bluetooth@...r.kernel.org, linux-wpan@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote:
> ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation
> phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to
> net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited.
> 
> Suggested-by: Ido Schimmel <idosch@...sch.org>
> Signed-off-by: Wang Liang <wangliang74@...wei.com>
> ---
> Changes in v2:
> Use dynamic debug instead of sysctl.

Thanks, I agree this addresses Ido's review of v1.
And, moreover, is a good approach the problem at hand.