linux-kernel - Re: [PATCH v4] selftests/futex: Convert 32bit timespec struct to 64bit version for 32bit compatibility mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61f90ebf-3cb4-4e81-a7d7-cfffe41d9d47@igalia.com>
Date: Fri, 4 Jul 2025 12:49:36 -0300
From: André Almeida <andrealmeid@...lia.com>
To: Terry Tritton <terry.tritton@...aro.org>
Cc: ttritton@...gle.com, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, linux-kselftest@...r.kernel.org,
 Thomas Gleixner <tglx@...utronix.de>, Darren Hart <dvhart@...radead.org>,
 linux-kernel@...r.kernel.org, Wei Gao <wegao@...e.com>,
 Davidlohr Bueso <dave@...olabs.net>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH v4] selftests/futex: Convert 32bit timespec struct to
 64bit version for 32bit compatibility mode

Hi Terry

Em 04/07/2025 07:35, Terry Tritton escreveu:
> sys_futex_wait() can not accept old_timespec32 struct, so userspace should
> convert it from 32bit to 64bit before syscall to support 32bit compatible mode.
> 
> This fix is based off [1]
> 
> Link: https://lore.kernel.org/all/20231203235117.29677-1-wegao@suse.com/ [1]
> 
> Originally-by: Wei Gao <wegao@...e.com>
> Signed-off-by: Terry Tritton <terry.tritton@...aro.org>
> ---

Thanks! It fixes the test when compiling with -m32.

However, please check the results ./scripts/checkpatch.pl, there are a 
lot of codestyle errors:

ERROR: trailing whitespace
#37: FILE: tools/testing/selftests/futex/include/futex2test.h:69:
+        struct __kernel_timespec ts = { $

ERROR: code indent should use tabs where possible
#37: FILE: tools/testing/selftests/futex/include/futex2test.h:69:
+        struct __kernel_timespec ts = { $

WARNING: please, no spaces at the start of a line
#37: FILE: tools/testing/selftests/futex/include/futex2test.h:69:
+        struct __kernel_timespec ts = { $

ERROR: trailing whitespace
#38: FILE: tools/testing/selftests/futex/include/futex2test.h:70:
+                .tv_sec = timo->tv_sec, $

ERROR: code indent should use tabs where possible
#38: FILE: tools/testing/selftests/futex/include/futex2test.h:70:
+                .tv_sec = timo->tv_sec, $

...