linux-kernel - Re: [PATCH] NDI FTDI USB driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025070427-pebble-stir-d4b0@gregkh>
Date: Fri, 4 Jul 2025 18:16:23 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Ryan Mann <rmann@...gital.com>
Cc: "johan@...nel.org" <johan@...nel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] NDI FTDI USB driver support

On Fri, Jul 04, 2025 at 02:44:46PM +0000, Ryan Mann wrote:
> NDI (Northern Digital Inc.) is introducing a new product called the EMGUIDE GEMINI that will use an FTDI chip for USB serial communications. The EMGUIDE GEMINI will support 1.2Mbaud the same as other NDI FTDI USB serial devices, by mapping the 19200. It was noticed in making this change that the NDI Aurora was included in this "quirk", but it does not support rates as high as 1.2Mbaud, so it was replaced by the EMGUIDE.
> This patch adds the new VID as "FTDI_NDI_VID" in the ftdi_sio_ids.h header file. It also reserves PID 0x0003 for the EMGUIDE GEMINI. Finally, it adds this VID/PID combination to the USB_DEVICE list in the ftdi_sio.c.

Please take the time, read the documentation, and then resend new
versions :)

You forgot to wrap your lines here.

And you forgot to version your patch.

And you included the old version of the patch below this patch, making
it impossible to apply.

Take the weekend, relax, and come back with a version 3 of this next
week.  There's no rush here.

thanks,

greg k-h