linux-kernel - Re: [PATCH V1 2/2] scsi: ufs: qcom: Enable QUnipro Internal Clock Gating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e82f971-8a1f-45c9-8f8a-9ef17f8c1a70@quicinc.com>
Date: Fri, 4 Jul 2025 09:52:45 +0530
From: Nitin Rawat <quic_nitirawa@...cinc.com>
To: Avri Altman <Avri.Altman@...disk.com>,
        "mani@...nel.org"
	<mani@...nel.org>,
        "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>,
        "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
        "konrad.dybcio@....qualcomm.com" <konrad.dybcio@....qualcomm.com>
CC: "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH V1 2/2] scsi: ufs: qcom: Enable QUnipro Internal Clock
 Gating



On 7/3/2025 12:13 PM, Avri Altman wrote:
>> +/**
>> + * ufshcd_dme_rmw - get modify set a dme attribute
>> + * @hba - per adapter instance
>> + * @mask - mask to apply on read value
>> + * @val - actual value to write
>> + * @attr - dme attribute
>> + */
>> +static inline int ufshcd_dme_rmw(struct ufs_hba *hba, u32 mask,
>> +                                u32 val, u32 attr) {
>> +       u32 cfg = 0;
>> +       int err = 0;
>> +
>> +       err = ufshcd_dme_get(hba, UIC_ARG_MIB(attr), &cfg);
>> +       if (err)
>> +               goto out;
>> +
>> +       cfg &= ~mask;
>> +       cfg |= (val & mask);
>> +
>> +       err = ufshcd_dme_set(hba, UIC_ARG_MIB(attr), cfg);
>> +
>> +out:
>> +       return err;
>> +}
> Might be useful to share this with other vendors as well. Maybe in ufshcd-priv.h ?
Sure Avri, I'll move this to ufshcd-priv.h

> 
> Thanks,
> Avri