linux-kernel - Re: [PATCH v9 5/9] mailbox: add CIX mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY1pzut-A9Xf117AoGMze2OevWKYrH5NtWBGFBhAMZky+A@mail.gmail.com>
Date: Fri, 4 Jul 2025 13:35:51 -0500
From: Jassi Brar <jassisinghbrar@...il.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Peter Chen <peter.chen@...tech.com>, Rob Herring <robh@...nel.org>, krzk+dt@...nel.org, 
	Conor Dooley <conor+dt@...nel.org>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	cix-kernel-upstream@...tech.com, Marc Zyngier <maz@...nel.org>, 
	Sudeep Holla <sudeep.holla@....com>, Kajetan Puchalski <kajetan.puchalski@....com>, 
	Enric Balletbo <eballetb@...hat.com>, Guomin Chen <Guomin.Chen@...tech.com>, 
	Gary Yang <gary.yang@...tech.com>, Lihua Liu <Lihua.Liu@...tech.com>
Subject: Re: [PATCH v9 5/9] mailbox: add CIX mailbox driver

On Fri, Jul 4, 2025 at 11:05 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Mon, Jun 9, 2025, at 05:16, Peter Chen wrote:
> > From: Guomin Chen <Guomin.Chen@...tech.com>
> >
> > The CIX mailbox controller, used in the Cix SoCs, like sky1.
> > facilitates message transmission between multiple processors
> > within the SoC, such as the AP, PM, audio DSP, SensorHub MCU,
> > and others.
> >
> > Reviewed-by: Peter Chen <peter.chen@...tech.com>
> > Signed-off-by: Guomin Chen <Guomin.Chen@...tech.com>
> > Signed-off-by: Gary Yang <gary.yang@...tech.com>
> > Signed-off-by: Lihua Liu <Lihua.Liu@...tech.com>
> > Signed-off-by: Peter Chen <peter.chen@...tech.com>
>
> This is the only driver holding up the merge of the CIX
> platform, so I had a closer look myself.
>
Sorry I wasn't made aware of this. Also I normally let the drivers
roast until second half
hoping other platform folks find issues - I have reduced imposing my
opinions on platform
specific code because it is usually met with some sledge-hammer requirement.

>
> The one thing that stuck out to me is the design of
> having multiple types of mailbox in one driver, which
> feels out of scope for a simple mailbox.
>
Yes, if not all modes are used currently, maybe drop unused ones.

I will review the rest separately.

Thanks.