linux-kernel - Re: [PATCH v5 0/3] PM: domains: Detach on device_unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gH9ZAK9br58KB0VEtG+4VdwO7vEKtrKbpcYOKnZPf7bg@mail.gmail.com>
Date: Fri, 4 Jul 2025 21:53:02 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Claudiu <claudiu.beznea@...on.dev>, rafael@...nel.org, linux@...linux.org.uk, 
	gregkh@...uxfoundation.org, david.m.ertman@...el.com, ira.weiny@...el.com, 
	leon@...nel.org, dakr@...nel.org, len.brown@...el.com, pavel@...nel.org, 
	andersson@...nel.org, mturquette@...libre.com, sboyd@...nel.org, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, wsa+renesas@...g-engineering.com, 
	mathieu.poirier@...aro.org, vkoul@...nel.org, yung-chuan.liao@...ux.intel.com, 
	pierre-louis.bossart@...ux.dev, broonie@...nel.org, robh@...nel.org, 
	jirislaby@...nel.org, saravanak@...gle.com, jic23@...nel.org, 
	dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-mmc@...r.kernel.org, linux-remoteproc@...r.kernel.org, 
	linux-sound@...r.kernel.org, linux-spi@...r.kernel.org, 
	linux-serial@...r.kernel.org, bhelgaas@...gle.com, geert@...ux-m68k.org, 
	linux-iio@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	fabrizio.castro.jz@...esas.com, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v5 0/3] PM: domains: Detach on device_unbind_cleanup()

On Fri, Jul 4, 2025 at 1:16 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Thu, 3 Jul 2025 at 13:27, Claudiu <claudiu.beznea@...on.dev> wrote:
> >
> > From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> >
> > Hi,
> >
> > Series drops the dev_pm_domain_detach() from platform bus remove and
> > adds it in device_unbind_cleanup() to avoid runtime resumming the device
> > after it was detached from its PM domain.
> >
> > Please provide your feedback.
> >
> > Thank you,
> > Claudiu
> >
> > Changes in v5:
> > - added PD_FLAG_ATTACH_POWER_ON, PD_FLAG_DETACH_POWER_OFF;
> >   due to this a new patch was introduced
> >   "PM: domains: Add flags to specify power on attach/detach"
> >
> > Changes in v4:
> > - added a flag in dev_pm_info that is saved in dev_pm_domain_attach()
> >   and used in device_unbind_cleanup()
> >
> > Changes in v3:
> > - add devm_pm_domain_attach()
> >
> > Changes in v2:
> > - dropped the devres group open/close approach and use
> >   devm_pm_domain_attach()
> > - adjusted patch description to reflect the new approach
> >
> >
> > Claudiu Beznea (3):
> >   PM: domains: Add flags to specify power on attach/detach
> >   PM: domains: Detach on device_unbind_cleanup()
> >   driver core: platform: Drop dev_pm_domain_detach() call
> >
> >  drivers/amba/bus.c                       |  4 ++--
> >  drivers/base/auxiliary.c                 |  2 +-
> >  drivers/base/dd.c                        |  2 ++
> >  drivers/base/platform.c                  |  9 +++------
> >  drivers/base/power/common.c              |  9 ++++++---
> >  drivers/clk/qcom/apcs-sdx55.c            |  2 +-
> >  drivers/gpu/drm/display/drm_dp_aux_bus.c |  2 +-
> >  drivers/i2c/i2c-core-base.c              |  2 +-
> >  drivers/mmc/core/sdio_bus.c              |  2 +-
> >  drivers/rpmsg/rpmsg_core.c               |  2 +-
> >  drivers/soundwire/bus_type.c             |  2 +-
> >  drivers/spi/spi.c                        |  2 +-
> >  drivers/tty/serdev/core.c                |  2 +-
> >  include/linux/pm.h                       |  1 +
> >  include/linux/pm_domain.h                | 10 ++++++++--
> >  15 files changed, 31 insertions(+), 22 deletions(-)
> >
> > --
> > 2.43.0
> >
>
> The series looks good to me, please add:
> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
>
> Rafael, do you intend to pick this via your tree?

I do in general, but I haven't looked at this version yet.  I'll get
to it early next week.