linux-kernel - Re: [PATCH v8 11/15] khugepaged: allow madvise_collapse to check all anonymous mTHP orders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250704141422.359c89146ad69512b9be4902@linux-foundation.org>
Date: Fri, 4 Jul 2025 14:14:22 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc: Nico Pache <npache@...hat.com>, linux-mm@...ck.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, david@...hat.com, ziy@...dia.com,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, ryan.roberts@....com,
 dev.jain@....com, corbet@....net, rostedt@...dmis.org, mhiramat@...nel.org,
 mathieu.desnoyers@...icios.com, baohua@...nel.org, willy@...radead.org,
 peterx@...hat.com, wangkefeng.wang@...wei.com, usamaarif642@...il.com,
 sunnanyong@...wei.com, vishal.moola@...il.com,
 thomas.hellstrom@...ux.intel.com, yang@...amperecomputing.com,
 kirill.shutemov@...ux.intel.com, aarcange@...hat.com, raquini@...hat.com,
 anshuman.khandual@....com, catalin.marinas@....com, tiwai@...e.de,
 will@...nel.org, dave.hansen@...ux.intel.com, jack@...e.cz, cl@...two.org,
 jglisse@...gle.com, surenb@...gle.com, zokeefe@...gle.com,
 hannes@...xchg.org, rientjes@...gle.com, mhocko@...e.com,
 rdunlap@...radead.org
Subject: Re: [PATCH v8 11/15] khugepaged: allow madvise_collapse to check
 all anonymous mTHP orders

On Fri, 4 Jul 2025 14:11:13 +0800 Baolin Wang <baolin.wang@...ux.alibaba.com> wrote:

> On 2025/7/2 13:57, Nico Pache wrote:
> > Allow madvise_collapse to scan/collapse all mTHP orders without the
> > strict requirement of needing the PMD-order enabled.
> > 
> > Signed-off-by: Nico Pache <npache@...hat.com>
> 
> I am afraid we should drop this patch from the series, since Hugh 
> explicitly opposed my modification of the madvise_collapse control logic 
> in this thread[1].

Well it drops easily enough.  I don't know if it compiles yet.

Nico, can you confirm that you're OK with the droppage and that the
series is still good without this patch?

> Moreover, since we have not yet clarified how to handle the conflict 
> between the semantics of madvise_collapse and the THP interfaces, we 
> should keep the current logic[2] (means madvise_collapse still only 
> allows PMD collapse).
> 
> If madvise_collapse is to support mTHP collapse, there will be more 
> semantic conflicts to discuss.
> 
> [1] 
> https://lore.kernel.org/all/cover.1750815384.git.baolin.wang@linux.alibaba.com/
> [2] 
> https://lore.kernel.org/all/23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.com/