linux-kernel - Re: [PATCH 2/5] arm64: dts: allwinner: a100: Add pin definitions for RGMII/RMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250704234528.4936fa72@minigeek.lan>
Date: Fri, 4 Jul 2025 23:45:28 +0100
From: Andre Przywara <andre.przywara@....com>
To: Paul Kocialkowski <paulk@...-base.io>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Chen-Yu
 Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel
 Holland <samuel@...lland.org>, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 2/5] arm64: dts: allwinner: a100: Add pin definitions
 for RGMII/RMII

On Thu, 26 Jun 2025 10:09:20 +0200
Paul Kocialkowski <paulk@...-base.io> wrote:

Hi,

> The Allwinner A100/A133 supports both RGMII and RMII for its Ethernet
> MAC (EMAC) controller. Add corresponding pin definitions.

Apart from suffixing everything with "0" ("rgmii0_pins: rgmii0-pins"),
this matches exactly what I gathered from manual and tested in my own
version of this patch a few weeks ago, so with the 0 suffix attached:

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> 
> Signed-off-by: Paul Kocialkowski <paulk@...-base.io>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> index bd366389b238..1c4e71b32911 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi
> @@ -236,6 +236,21 @@ mmc2_pins: mmc2-pins {
>  				bias-pull-up;
>  			};
>  
> +			rgmii_pins: rgmii-pins {
> +				pins = "PH0", "PH1", "PH2", "PH3", "PH4",
> +				       "PH5", "PH6", "PH7", "PH9", "PH10",
> +				       "PH14", "PH15", "PH16", "PH17", "PH18";
> +				function = "emac";
> +				drive-strength = <40>;
> +			};
> +
> +			rmii_pins: rmii-pins {
> +				pins = "PH0", "PH1", "PH2", "PH3", "PH4",
> +				       "PH5", "PH6", "PH7", "PH9", "PH10";
> +				function = "emac";
> +				drive-strength = <40>;
> +			};
> +
>  			uart0_pb_pins: uart0-pb-pins {
>  				pins = "PB9", "PB10";
>  				function = "uart0";