linux-kernel - Re: [syzbot] [kernel?] UBSAN: shift-out-of-bounds in pcl812

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250704234551.2525-1-hdanton@sina.com>
Date: Sat,  5 Jul 2025 07:45:32 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+32de323b0addb9e114ff@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [kernel?] UBSAN: shift-out-of-bounds in pcl812_attach

> Date: Fri, 04 Jul 2025 14:50:49 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    4c06e63b9203 Merge tag 'for-6.16-rc4-tag' of git://git.ker..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=104a8f70580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=b29b1a0d7330d4a8
> dashboard link: https://syzkaller.appspot.com/bug?extid=32de323b0addb9e114ff
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16b17ebc580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=144a8f70580000

#syz test

--- x/drivers/comedi/drivers/pcl812.c
+++ y/drivers/comedi/drivers/pcl812.c
@@ -1148,6 +1148,8 @@ static int pcl812_attach(struct comedi_d
 					 I8254_OSC_BASE_2MHZ, I8254_IO8, 0);
 		if (IS_ERR(dev->pacer))
 			return PTR_ERR(dev->pacer);
+		if (it->options[1] < 0 || it->options[1] > 31)
+			return -EINVAL;
 
 		if ((1 << it->options[1]) & board->irq_bits) {
 			ret = request_irq(it->options[1], pcl812_interrupt, 0,
--