linux-kernel - Re: [PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in facebook-bmc-flash-layout-128.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78f9fcbc58261064f248e95eb7740549e338bc78.camel@codeconstruct.com.au>
Date: Fri, 04 Jul 2025 09:36:29 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: rentao.bupt@...il.com, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel
 Stanley <joel@....id.au>, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
 linux-kernel@...r.kernel.org, Tao Ren <taoren@...a.com>
Subject: Re: [PATCH 1/5] ARM: dts: aspeed: Expand data0 partition in
 facebook-bmc-flash-layout-128.dtsi

On Tue, 2025-07-01 at 22:04 -0700, rentao.bupt@...il.com wrote:
> From: Tao Ren <rentao.bupt@...il.com>
> 
> Expand data0 partition to 64MB in facebook-bmc-flash-layout-128.dtsi for
> larger persistent storage.
> 
> Signed-off-by: Tao Ren <rentao.bupt@...il.com>
> ---
>  .../boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> index 7f3652dea550..efd92232cda2 100644
> --- a/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> +++ b/arch/arm/boot/dts/aspeed/facebook-bmc-flash-layout-128.dtsi
> @@ -32,19 +32,19 @@ image-meta@...00 {
>         };
>  
>         /*
> -        * FIT image: 119 MB.
> +        * FIT image: 63 MB.
>          */
>         fit@...000 {
> -               reg = <0x100000 0x7700000>;
> +               reg = <0x100000 0x3f00000>;
>                 label = "fit";
>         };
>  
>         /*
> -        * "data0" partition (8MB) is used by Facebook BMC platforms as
> +        * "data0" partition (64MB) is used by Facebook BMC platforms as
>          * persistent data store.
>          */
> -       data0@...0000 {
> -               reg = <0x7800000 0x800000>;
> +       data0@...0000 {
> +               reg = <0x4000000 0x4000000>;
>                 label = "data0";
>         };
>  

Two existing systems use this dtsi:

   > git grep facebook-bmc-flash-layout-128.dtsi
   arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-wedge400.dts:#include "facebook-bmc-flash-layout-128.dtsi"
   arch/arm/boot/dts/aspeed/ast2600-facebook-netbmc-common.dtsi:#include "facebook-bmc-flash-layout-128.dtsi"

This change requires a full reflash of those devices, which is pretty
disruptive.

It seems more appropriate to me to create a separate dtsi for the new
flash layout to use in new systems.

Andrew