linux-kernel - Re: [RFC PATCH v5 2/3] virtio-spi: Add virtio-spi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80b54138-b5ae-49db-8e94-42de6de05bf8@quicinc.com>
Date: Fri, 4 Jul 2025 14:54:08 +0800
From: Haixu Cui <quic_haixcui@...cinc.com>
To: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>, <broonie@...nel.org>,
        <virtio-dev@...ts.linux.dev>, <viresh.kumar@...aro.org>,
        <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hdanton@...a.com>, <qiang4.zhang@...ux.intel.com>,
        <alex.bennee@...aro.org>
CC: <quic_ztu@...cinc.com>
Subject: Re: [RFC PATCH v5 2/3] virtio-spi: Add virtio-spi.h



On 6/30/2025 2:59 PM, Mukesh Kumar Savaliya wrote:
> 
> 
> On 6/20/2025 9:42 AM, Haixu Cui wrote:
>> Add virtio-spi.h header for virtio SPI.
>>
>> Signed-off-by: Haixu Cui <quic_haixcui@...cinc.com>
>> ---
>>   include/uapi/linux/virtio_spi.h | 185 ++++++++++++++++++++++++++++++++
>>   1 file changed, 185 insertions(+)
>>   create mode 100644 include/uapi/linux/virtio_spi.h

>> + * @max_cs_setup_ns: the maximum delay supported after chipselect is 
>> asserted,
> And before clock start. may also sound good, if we can write "delay 
> between CS assert to clock start"

I follow the existing comment in 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/spi/spi.h?h=v6.16-rc4#n166, 
where the cs_setup is described only in terms of the delay after CS is 
asserted, without explicitly referencing the clock signal.
To maintain consistency, I kept the comment focused on the relationship 
between the delay and the CS signal alone.