[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49b49005-e857-445e-8b63-e84cbfdae17b@lunn.ch>
Date: Fri, 4 Jul 2025 10:16:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Andre Edich <andre.edich@...rochip.com>, kernel@...gutronix.de,
linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
netdev@...r.kernel.org, Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH net v2 2/3] net: phy: smsc: Force predictable MDI-X state
on LAN87xx
> The patch looks good to me, but I have a few questions. As this
> overrides some configuration on existing HW, and I'm not utra familiar
> with auto-mdix, is there any chance this could cause regressions ?
>
> Especially regarding your patch 3, is there any chance that the PHY is
> strapped in a fixed MDIX mode to address the broken autoneg off mode ?
>
> I'm not saying that strapping is a good solution for that ofc :) it's a
> shame we can't read the strap config :/
This might technically be considered a behaviour change. However there
are few systems which don't support it. It is also independent of
auto-neg, so autoneg off should not be an issue.
I think this is reasonably safe, and if somebody does report a
regression, we can revert the patch.
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists