linux-kernel - Re: [PATCH 1/4] iopoll: Generalize read_poll_timeout() into poll_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edb1261d2cb3addea74d07e8be4d8eb54613ab54@intel.com>
Date: Fri, 04 Jul 2025 11:40:20 +0300
From: Jani Nikula <jani.nikula@...el.com>
To: Lucas De Marchi <lucas.demarchi@...el.com>, Ville Syrjala
 <ville.syrjala@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Dibin
 Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@...el.com>, Imre
 Deak <imre.deak@...el.com>, David Laight <david.laight.linux@...il.com>,
 Geert
 Uytterhoeven <geert+renesas@...der.be>, Matt Wagantall
 <mattw@...eaurora.org>, Dejin Zheng <zhengdejin5@...il.com>,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org
Subject: Re: [PATCH 1/4] iopoll: Generalize read_poll_timeout() into
 poll_timeout_us()

On Thu, 03 Jul 2025, Lucas De Marchi <lucas.demarchi@...el.com> wrote:
> On Thu, Jul 03, 2025 at 01:34:36AM +0300, Ville Syrjälä wrote:
>>-#define read_poll_timeout(op, val, cond, sleep_us, timeout_us, \
>>-				sleep_before_read, args...) \
>>+#define poll_timeout_us(op, cond, sleep_us, timeout_us, sleep_before_op) \
>
> nit: could use use usec/msec etc that pairs nicely with USEC_PER_SEC
> and friends, also used by tools like perf and are a little bit more
> greppable than ms/us?

This horrendous quick and dirty git grep popularity contest says _us/_ms
suffixes are much more popular than _usec/_msec in kernel:

$ git grep -aoh "_[mu]s\(ec\)\?[^a-zA-Z0-9_]" | sed 's/[^a-zA-Z0-9_]$//' | sort | uniq -c | sort -rn
   8603 _us
   5901 _ms
   1214 _usec
    736 _msec

BR,
Jani.

-- 
Jani Nikula, Intel