linux-kernel - Re: [PATCH v6 2/6] rust: irq: add flags module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mA3c-gs5CZ5F2U6zkWU=X7kHcgWVsvXkHpvv9mXeoY2Q@mail.gmail.com>
Date: Fri, 4 Jul 2025 11:31:34 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Daniel Sedlak <daniel@...lak.dev>
Cc: Daniel Almeida <daniel.almeida@...labora.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Benno Lossin <lossin@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v6 2/6] rust: irq: add flags module

On Fri, Jul 4, 2025 at 8:14 AM Daniel Sedlak <daniel@...lak.dev> wrote:
>
> Why not Flags(u32)? You may get rid of all unnecessary casts later, plus
> save some extra bytes.

Yeah, avoiding the casts would be nice -- however it is done.

On the patch: it wouldn't hurt to add an example for each of the
operators too. Even better if it is a common use case of each (say,
for `|`, a common combination of these flags).

(By the way, the use of the `into_inner()` name here is another one we
will want to discuss for the new naming guidelines table.)

Thanks!

Cheers,
Miguel