linux-kernel - Re: [PATCH] staging: media: atomisp: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0614e1c-2966-4766-999c-2bc58d643e7e@kernel.org>
Date: Fri, 4 Jul 2025 11:42:58 +0200
From: Hans de Goede <hansg@...nel.org>
To: Pablo <pablo@...lo.ct.ws>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
 hdegoede@...hat.com, mchehab@...nel.org, sakari.ailus@...ux.intel.com,
 andy@...nel.org, gregkh@...uxfoundation.org
Cc: ~lkcamp/patches@...ts.sr.ht, koike@...lia.com, pablolucas890@...il.com
Subject: Re: [PATCH] staging: media: atomisp: fix coding style

On 3-May-25 10:00 PM, Pablo wrote:
> Fix a coding style:
> "ERROR: that open brace { should be on the previous line"
> issue reported in ia_css_vf.host.c:94.
> 
> Signed-off-by: Pablo <pablo@...lo.ct.ws>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  Hey, this is my first patch, I apreciate any feedback, thanks!
>  .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c   | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> index ece5e3da3..0ce75d9bd 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> @@ -91,8 +91,7 @@ configure_kernel(
>  	unsigned int vf_log_ds = 0;
>  
>  	/* First compute value */
> -	if (vf_info)
> -	{
> +	if (vf_info) {
>  		err = sh_css_vf_downscale_log2(out_info, vf_info, &vf_log_ds);
>  		if (err)
>  			return err;