linux-kernel - Re: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68b4d53f-a185-4e11-af1e-532fc45cb8b2@igalia.com>
Date: Fri, 4 Jul 2025 07:24:46 -0300
From: Maíra Canal <mcanal@...lia.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Douglas Anderson <dianders@...omium.org>,
 Lucas Stach <l.stach@...gutronix.de>,
 Russell King <linux+etnaviv@...linux.org.uk>,
 Christian Gmeiner <christian.gmeiner@...il.com>,
 Inki Dae <inki.dae@...sung.com>, Seung-Woo Kim <sw0312.kim@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>,
 Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar
 <alim.akhtar@...sung.com>, Jani Nikula <jani.nikula@...ux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin
 <tursulin@...ulin.net>, Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Qiang Yu <yuq825@...il.com>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Steven Price <steven.price@....com>, Liviu Dudau <liviu.dudau@....com>,
 Thierry Reding <thierry.reding@...il.com>,
 Mikko Perttunen <mperttunen@...dia.com>,
 Jonathan Hunter <jonathanh@...dia.com>, Jyri Sarha <jyri.sarha@....fi>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Damon Ding <damon.ding@...k-chips.com>,
 Ayushi Makhija <quic_amakhija@...cinc.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Chen-Yu Tsai <wenst@...omium.org>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 etnaviv@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
 imx@...ts.linux.dev, lima@...ts.freedesktop.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 20/80] drivers: drm: Remove redundant
 pm_runtime_mark_last_busy() calls

Hi Sakari,

On 04/07/25 04:54, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> ---

[...]

> diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
> index bb09df5000bd..11ec7e913974 100644
> --- a/drivers/gpu/drm/vc4/vc4_v3d.c
> +++ b/drivers/gpu/drm/vc4/vc4_v3d.c
> @@ -153,7 +153,6 @@ vc4_v3d_pm_put(struct vc4_dev *vc4)
>   
>   	mutex_lock(&vc4->power_lock);
>   	if (--vc4->power_refcount == 0) {
> -		pm_runtime_mark_last_busy(&vc4->v3d->pdev->dev);
>   		pm_runtime_put_autosuspend(&vc4->v3d->pdev->dev);
>   	}

Nit: please, drop the curly braces.

>   	mutex_unlock(&vc4->power_lock);

For vc4,

Reviewed-by: Maíra Canal <mcanal@...lia.com>

Best Regards,
- Maíra