linux-kernel - Re: [PATCH v4 3/5] mm,hugetlb: rename anon_rmap to new_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3184cd54-416b-4456-aeff-0d8165beffac@redhat.com>
Date: Fri, 4 Jul 2025 12:46:51 +0200
From: David Hildenbrand <david@...hat.com>
To: Oscar Salvador <osalvador@...e.de>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Muchun Song <muchun.song@...ux.dev>, Peter Xu <peterx@...hat.com>,
 Gavin Guo <gavinguo@...lia.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/5] mm,hugetlb: rename anon_rmap to new_anon_folio and
 make it boolean

On 30.06.25 16:42, Oscar Salvador wrote:
> anon_rmap is used to determine whether the new allocated folio is
> anonymous.  Rename it to something more meaningul like new_anon_folio and
> make it boolean, as we use it like that.
> 
> While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is
> enough to check whether we need to restore the consumed reservation.
> 
> Link: https://lkml.kernel.org/r/20250627102904.107202-4-osalvador@suse.de
> Signed-off-by: Oscar Salvador <osalvador@...e.de>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Gavin Guo <gavinguo@...lia.com>
> Cc: Muchun Song <muchun.song@...ux.dev>
> Cc: Peter Xu <peterx@...hat.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

BTW, these SOB are wrong :)

> ---

Nothing jumped at me, but it's all very complicated stuff

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb